chrome/browser/download/download_create_info.cc - Issue 7112011: Change DownloadProcessHandle to be more of an encapsulated class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_create_info.cc

Issue 7112011: Change DownloadProcessHandle to be more of an encapsulated class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Get rid of cancel code in download_util. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_create_info.cc

diff --git a/chrome/browser/download/download_create_info.cc b/chrome/browser/download/download_create_info.cc

index 8a77e821c2bd337a02a306c00c9c0e0b06dd8677..47cc1952736538c15dbb7197c115c8a160ae5d51 100644

--- a/chrome/browser/download/download_create_info.cc

+++ b/chrome/browser/download/download_create_info.cc

@@ -53,9 +53,7 @@ std::string DownloadCreateInfo::DebugString() const {

" path = \"%" PRFilePath "\""

" received_bytes = %" PRId64

" total_bytes = %" PRId64

- " child_id = %d"

- " render_view_id = %d"

- " request_id = %d"

+ " process_handle = %s"

" prompt_user_for_save_location = %c"

" }",

download_id,

@@ -63,9 +61,7 @@ std::string DownloadCreateInfo::DebugString() const {

path.value().c_str(),

received_bytes,

total_bytes,

- process_handle.child_id(),

- process_handle.render_view_id(),

- process_handle.request_id(),

+ process_handle.DebugString().c_str(),

prompt_user_for_save_location ? 'T' : 'F');

}