Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: chrome/browser/download/download_manager.h

Issue 7112011: Change DownloadProcessHandle to be more of an encapsulated class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged to LKGR. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_item.cc ('k') | chrome/browser/download/download_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_manager.h
diff --git a/chrome/browser/download/download_manager.h b/chrome/browser/download/download_manager.h
index 79018bec672195496af041f0f6dbaff25c8d91de..2ad70301f26504ce2f0d4a07a24ada837da0fdf6 100644
--- a/chrome/browser/download/download_manager.h
+++ b/chrome/browser/download/download_manager.h
@@ -42,8 +42,8 @@
#include "base/scoped_ptr.h"
#include "base/time.h"
#include "chrome/browser/download/download_item.h"
+#include "chrome/browser/download/download_request_handle.h"
#include "chrome/browser/download/download_status_updater_delegate.h"
-#include "chrome/browser/download/download_process_handle.h"
#include "chrome/browser/ui/shell_dialogs.h"
#include "content/browser/browser_thread.h"
@@ -124,7 +124,6 @@ class DownloadManager
// Called from a view when a user clicks a UI button or link.
void DownloadCancelled(int32 download_id);
- void PauseDownload(int32 download_id, bool pause);
void RemoveDownload(int64 download_handle);
// Determine if the download is ready for completion, i.e. has had
@@ -299,10 +298,10 @@ class DownloadManager
const FilePath& chosen_file);
// Download cancel helper function.
- // |process_handle| is passed by value because it is ultimately passed to
+ // |request_handle| is passed by value because it is ultimately passed to
// other threads, and this way we don't have to worry about object lifetimes.
void DownloadCancelledInternal(int download_id,
- DownloadProcessHandle process_handle);
+ DownloadRequestHandle request_handle);
// All data has been downloaded.
// |hash| is sha256 hash for the downloaded file. It is empty when the hash
@@ -315,14 +314,6 @@ class DownloadManager
// Updates the app icon about the overall download progress.
void UpdateAppIcon();
- // Makes the ResourceDispatcherHost pause/un-pause a download request.
- // Called on the IO thread.
- // |process_handle| is passed by value because this is called from other
- // threads, and this way we don't have to worry about object lifetimes.
- void PauseDownloadRequest(ResourceDispatcherHost* rdh,
- DownloadProcessHandle process_handle,
- bool pause);
-
// Inform observers that the model has changed.
void NotifyModelChanged();
« no previous file with comments | « chrome/browser/download/download_item.cc ('k') | chrome/browser/download/download_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698