Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 7112010: Plumbing changes to merge various element kind implementaions. (Closed)

Created:
9 years, 6 months ago by danno
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Dispatch on ElementsKind rather than ExternalArrayType when generating ICs and Crankshaft code for many element operations. This is preparation to be able to share more code in the various element accessor implementations. Merge logic to maintain external array and fast element stub caches. BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=8244

Patch Set 1 #

Patch Set 2 : first try #

Patch Set 3 : implement all platforms #

Patch Set 4 : remove stray break #

Total comments: 24

Patch Set 5 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+536 lines, -764 lines) Patch
M src/arm/lithium-arm.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 3 4 3 chunks +18 lines, -13 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 4 7 chunks +38 lines, -30 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 2 3 4 22 chunks +99 lines, -116 lines 0 comments Download
M src/ast.h View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M src/ast.cc View 1 3 chunks +0 lines, -9 lines 0 comments Download
M src/code-stubs.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap.h View 1 2 3 4 1 chunk +8 lines, -8 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 2 chunks +17 lines, -13 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 6 chunks +15 lines, -13 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 2 chunks +30 lines, -20 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 4 chunks +39 lines, -32 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 3 chunks +19 lines, -15 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 3 4 17 chunks +63 lines, -100 lines 0 comments Download
M src/ic.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/ic.cc View 1 6 chunks +13 lines, -17 lines 0 comments Download
M src/lithium.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/lithium.cc View 1 2 3 4 1 chunk +15 lines, -11 lines 0 comments Download
M src/objects.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +0 lines, -13 lines 0 comments Download
M src/stub-cache.h View 5 chunks +5 lines, -38 lines 0 comments Download
M src/stub-cache.cc View 3 chunks +5 lines, -118 lines 0 comments Download
M src/type-info.h View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M src/type-info.cc View 1 2 3 4 1 chunk +0 lines, -14 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 4 chunks +39 lines, -32 lines 0 comments Download
M src/x64/lithium-x64.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 3 chunks +18 lines, -13 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 13 chunks +64 lines, -92 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danno
Please review. Reviewer guidance: Most of the changes are purely mechanical, However, there are two ...
9 years, 6 months ago (2011-06-09 12:58:42 UTC) #1
Mads Ager (chromium)
http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-arm.cc#newcode2002 src/arm/lithium-arm.cc:2002: bool val_is_temp_register = elements_kind == (elements_kind == A) || ...
9 years, 6 months ago (2011-06-09 14:15:45 UTC) #2
Jakob Kummerow
Some of my comments are dupes of Mads' comments; I couldn't be bothered to filter ...
9 years, 6 months ago (2011-06-09 14:26:40 UTC) #3
danno
Feedback addressed, please take another look. http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-arm.cc#newcode2002 src/arm/lithium-arm.cc:2002: bool val_is_temp_register = ...
9 years, 6 months ago (2011-06-09 15:03:27 UTC) #4
Jakob Kummerow
9 years, 6 months ago (2011-06-09 15:12:14 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698