Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: src/array.js

Issue 7111032: Don't use SmartSlice just because the receiver is an array. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
624 end_i += len; 624 end_i += len;
625 if (end_i < 0) end_i = 0; 625 if (end_i < 0) end_i = 0;
626 } else { 626 } else {
627 if (end_i > len) end_i = len; 627 if (end_i > len) end_i = len;
628 } 628 }
629 629
630 var result = []; 630 var result = [];
631 631
632 if (end_i < start_i) return result; 632 if (end_i < start_i) return result;
633 633
634 if (IS_ARRAY(this)) { 634 if (IS_ARRAY(this) &&
635 (end_i > 1000) &&
636 (%EstimateNumberOfElements(this) < end_i)) {
635 SmartSlice(this, start_i, end_i - start_i, len, result); 637 SmartSlice(this, start_i, end_i - start_i, len, result);
636 } else { 638 } else {
637 SimpleSlice(this, start_i, end_i - start_i, len, result); 639 SimpleSlice(this, start_i, end_i - start_i, len, result);
638 } 640 }
639 641
640 result.length = end_i - start_i; 642 result.length = end_i - start_i;
641 643
642 return result; 644 return result;
643 } 645 }
644 646
(...skipping 712 matching lines...) Expand 10 before | Expand all | Expand 10 after
1357 InternalArray.prototype.join = getFunction("join", ArrayJoin); 1359 InternalArray.prototype.join = getFunction("join", ArrayJoin);
1358 InternalArray.prototype.pop = getFunction("pop", ArrayPop); 1360 InternalArray.prototype.pop = getFunction("pop", ArrayPop);
1359 InternalArray.prototype.push = getFunction("push", ArrayPush); 1361 InternalArray.prototype.push = getFunction("push", ArrayPush);
1360 InternalArray.prototype.toString = function() { 1362 InternalArray.prototype.toString = function() {
1361 return "Internal Array, length " + this.length; 1363 return "Internal Array, length " + this.length;
1362 }; 1364 };
1363 } 1365 }
1364 1366
1365 1367
1366 SetupArray(); 1368 SetupArray();
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698