Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 7111032: Don't use SmartSlice just because the receiver is an array. (Closed)

Created:
9 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Don't use SmartSlice just because the receiver is an array. Only do so if the estimated number of elements is low compared to the end position for the slice. This is similar to other heuristics used for array operations that use the %GetElementKeys runtime function. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=8184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/array.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 6 months ago (2011-06-06 12:30:21 UTC) #1
Erik Corry
9 years, 6 months ago (2011-06-06 13:26:09 UTC) #2
LGTM but it would be good to optimize the case where we are starting at a high
index.

Powered by Google App Engine
This is Rietveld 408576698