[ChromeOS] Add a "hardware-backed" suffix to tpm-backed cert.

[ChromeOS] Add a "hardware-backed" suffix to tpm-backed cert.

BUG=chromium-os:12302
TEST=Verify fix for chromium-os:12302

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88342

[xiyuan, 2011-06-03 20:45:30]

This CL finds TPM-backed certificate by comparing slot token name. Please let me
know if this is appropriate. If not, what would be the best way to find that
out.

Thanks.

[mattm, 2011-06-04 02:00:32]

http://codereview.chromium.org/7111014/diff/1/chrome/browser/certificate_mana...
File chrome/browser/certificate_manager_model.cc (right):

http://codereview.chromium.org/7111014/diff/1/chrome/browser/certificate_mana...
chrome/browser/certificate_manager_model.cc:91: if (cert_slot &&
PK11_GetTokenName(cert_slot) == tpm_token_name) {
If we want to do it by comparing the name, it could use
x509_certificate_model::GetTokenName instead of calling NSS directly here.

Alternatively I think we could do this by comparing the slot handles instead. 
Seems a bit cleaner, but I guess either way is fine.

[xiyuan, 2011-06-06 17:17:17]

CL updated. Please take another look. Thanks.

http://codereview.chromium.org/7111014/diff/1/chrome/browser/certificate_mana...
File chrome/browser/certificate_manager_model.cc (right):

http://codereview.chromium.org/7111014/diff/1/chrome/browser/certificate_mana...
chrome/browser/certificate_manager_model.cc:91: if (cert_slot &&
PK11_GetTokenName(cert_slot) == tpm_token_name) {
On 2011/06/04 02:00:32, mattm wrote:
> If we want to do it by comparing the name, it could use
> x509_certificate_model::GetTokenName instead of calling NSS directly here.
> 
> Alternatively I think we could do this by comparing the slot handles instead. 
> Seems a bit cleaner, but I guess either way is fine.

This is what I want to hear. I'd like to compare handle but was not sure whether
it is safe to do so. Changed to compare slot handle now.

[Greg Spencer (Chromium), 2011-06-06 18:01:56]

LGTM from my perspective.

[mattm, 2011-06-06 20:47:34]

lgtm with nit

http://codereview.chromium.org/7111014/diff/3001/chrome/browser/certificate_m...
File chrome/browser/certificate_manager_model.cc (right):

http://codereview.chromium.org/7111014/diff/3001/chrome/browser/certificate_m...
chrome/browser/certificate_manager_model.cc:23: #include
"net/base/x509_certificate.h"
these 2 already included above

[wtc, 2011-06-07 01:02:41]

LGTM.