Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 7111013: Move most of the core SSL code from chrome to content. The UI code that's specific to Chrome (i.... (Closed)

Created:
9 years, 6 months ago by jam
Modified:
9 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, brettw-cc_chromium.org, kkania, joi+watch-content_chromium.org
Visibility:
Public.

Description

Move most of the core SSL code from chrome to content. The UI code that's specific to Chrome (i.e. interstitial, dialogs) stays behind. This change just moves code, and so adds a bunch of files to DEPS. I'll add proper interfaces in a follow up cl, but keeping the move simple at first. BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87866

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -1957 lines) Patch
M chrome/browser/automation/automation_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/page_info_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ssl/ssl_cert_error_handler.h View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/ssl/ssl_cert_error_handler.cc View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/ssl/ssl_client_auth_handler.h View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/ssl/ssl_client_auth_handler.cc View 1 chunk +0 lines, -156 lines 0 comments Download
D chrome/browser/ssl/ssl_client_auth_notification_details.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/ssl/ssl_client_auth_notification_details.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/ssl/ssl_error_handler.h View 1 2 1 chunk +0 lines, -144 lines 0 comments Download
D chrome/browser/ssl/ssl_error_handler.cc View 1 2 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/browser/ssl/ssl_host_state.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/ssl/ssl_host_state.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ssl/ssl_host_state_unittest.cc View 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/browser/ssl/ssl_manager.h View 1 chunk +0 lines, -132 lines 0 comments Download
D chrome/browser/ssl/ssl_manager.cc View 1 chunk +0 lines, -264 lines 0 comments Download
D chrome/browser/ssl/ssl_policy.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/ssl/ssl_policy.cc View 1 chunk +0 lines, -226 lines 0 comments Download
D chrome/browser/ssl/ssl_policy_backend.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ssl/ssl_policy_backend.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/ssl/ssl_request_info.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ssl/ssl_request_info.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_ssl_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.cc View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_request_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/ssl/ssl_cert_error_handler.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/ssl/ssl_cert_error_handler.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
A + content/browser/ssl/ssl_client_auth_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/ssl/ssl_client_auth_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/ssl/ssl_client_auth_notification_details.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/ssl/ssl_client_auth_notification_details.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/ssl/ssl_error_handler.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/ssl/ssl_error_handler.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/ssl/ssl_host_state.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/ssl/ssl_host_state.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/ssl/ssl_host_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/ssl/ssl_manager.h View 1 3 chunks +4 lines, -8 lines 0 comments Download
A + content/browser/ssl/ssl_manager.cc View 1 2 2 chunks +4 lines, -21 lines 0 comments Download
A + content/browser/ssl/ssl_policy.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/ssl/ssl_policy.cc View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
A + content/browser/ssl/ssl_policy_backend.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/ssl/ssl_policy_backend.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/ssl/ssl_request_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/ssl/ssl_request_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/provisional_load_details.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 6 months ago (2011-06-03 19:59:04 UTC) #1
Avi (use Gerrit)
9 years, 6 months ago (2011-06-03 20:03:30 UTC) #2
rubber stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698