Return a new error code for multi-install updates if Group Policy settings blocking...

Return a new error code multi-install updates if Group Policy settings blocking updates for individual products are conflicting with the effective update policy for the multi-install binaries.

In so doing, I moved the GP update policy checking code that was in browser into installer_util.

BUG=none
TEST=Install multi-install Chrome version N-1, disable updates for Chrome, then try to update to version N.  With luck, you'll find that the update failed on account of inconsistent GP settings.
R=robertshield@chromium.org,pastarmovj@chromium.org,gwilson@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89384

[robertshield, 2011-06-08 16:06:51]

LGTM, one nit

http://codereview.chromium.org/7111012/diff/5010/chrome/installer/util/google...
File chrome/installer/util/google_update_settings.cc (right):

http://codereview.chromium.org/7111012/diff/5010/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:168:
dont_reorder_GoogleUpdateSettings_UpdatePolicy);
Can these asserts go near the enum declaration? I dislike having them in the
middle of function definitions.

[grt (UTC plus 2), 2011-06-08 16:31:32]

Thanks, Robert.

Julian: would you review the change to browser/...?
Glenn: would you review the strings in the .grd files and the log message in
setup_main.cc?  Also, could you send me a goo.gl URL that will (eventually)
redirect to a help topic relating to this?

http://codereview.chromium.org/7111012/diff/5010/chrome/installer/util/google...
File chrome/installer/util/google_update_settings.cc (right):

http://codereview.chromium.org/7111012/diff/5010/chrome/installer/util/google...
chrome/installer/util/google_update_settings.cc:168:
dont_reorder_GoogleUpdateSettings_UpdatePolicy);
On 2011/06/08 16:06:52, robertshield wrote:
> Can these asserts go near the enum declaration? I dislike having them in the
> middle of function definitions.

Done.

[Glenn Wilson, 2011-06-08 17:10:39]

Added a quick comment.  We should change the string to point them at exactly
what they need to do.  Only admins will see this message.

http://codereview.chromium.org/7111012/diff/9001/chrome/app/google_chrome_str...
File chrome/app/google_chrome_strings.grd (right):

http://codereview.chromium.org/7111012/diff/9001/chrome/app/google_chrome_str...
chrome/app/google_chrome_strings.grd:462: Google Chrome or Google Chrome Frame
cannot be updated on account of inconsistent Google Update Group Policy
settings. Please contact your administrator for assistance.
This isn't all that useful, because only admins will see this message.  We
should be explicit on what they need to do, and perhaps provide a URL they can
go to to resolve the problem.

[grt (UTC plus 2), 2011-06-08 19:42:04]

Thanks for having a look.

http://codereview.chromium.org/7111012/diff/9001/chrome/app/google_chrome_str...
File chrome/app/google_chrome_strings.grd (right):

http://codereview.chromium.org/7111012/diff/9001/chrome/app/google_chrome_str...
chrome/app/google_chrome_strings.grd:462: Google Chrome or Google Chrome Frame
cannot be updated on account of inconsistent Google Update Group Policy
settings. Please contact your administrator for assistance.
On 2011/06/08 17:10:39, Glenn Wilson wrote:
> This isn't all that useful, because only admins will see this message.  We
> should be explicit on what they need to do, and perhaps provide a URL they can
> go to to resolve the problem.

Are you still volunteering to write a help article for this?  If so, could you
send me a URL (goo.gl?) to put in the message?  I'll also put it in the log
message.  Thanks.

[Glenn Wilson, 2011-06-09 21:32:12]

On Wed, Jun 8, 2011 at 12:42 PM, <grt@chromium.org> wrote:

> Thanks for having a look.
>
>
>
> http://codereview.chromium.**org/7111012/diff/9001/chrome/**
>
app/google_chrome_strings.grd<http://codereview.chromium.org/7111012/diff/9001/chrome/app/google_chrome_strings.grd>
> File chrome/app/google_chrome_**strings.grd (right):
>
> http://codereview.chromium.**org/7111012/diff/9001/chrome/**
>
app/google_chrome_strings.grd#**newcode462<http://codereview.chromium.org/7111012/diff/9001/chrome/app/google_chrome_strings.grd#newcode462>
> chrome/app/google_chrome_**strings.grd:462: Google Chrome or Google Chrome
> Frame cannot be updated on account of inconsistent Google Update Group
> Policy settings. Please contact your administrator for assistance.
> On 2011/06/08 17:10:39, Glenn Wilson wrote:
>
>> This isn't all that useful, because only admins will see this message.
>>
>  We
>
>> should be explicit on what they need to do, and perhaps provide a URL
>>
> they can
>
>> go to to resolve the problem.
>>
>
> Are you still volunteering to write a help article for this?  If so,
> could you send me a URL (goo.gl?) to put in the message?  I'll also put
> it in the log message.  Thanks.


Yes, this is on my TODO list.

I'm thinking this should be hosted on google.com instead of chromium.org,
although that means it will likely take longer to do, get localized, etc.
 Are you ok with that kind of delay?

If so, I could provide you with a link to a google help center article.

>
>
>
http://codereview.chromium.**org/7111012/<http://codereview.chromium.org/7111...
>

[grt (UTC plus 2), 2011-06-13 14:01:10]

On Thu, Jun 9, 2011 at 5:32 PM, Glenn Wilson <gwilson@chromium.org> wrote:

>
>
> On Wed, Jun 8, 2011 at 12:42 PM, <grt@chromium.org> wrote:
>
>> Thanks for having a look.
>>
>>
>>
>> http://codereview.chromium.**org/7111012/diff/9001/chrome/**
>>
app/google_chrome_strings.grd<http://codereview.chromium.org/7111012/diff/9001/chrome/app/google_chrome_strings.grd>
>> File chrome/app/google_chrome_**strings.grd (right):
>>
>> http://codereview.chromium.**org/7111012/diff/9001/chrome/**
>>
app/google_chrome_strings.grd#**newcode462<http://codereview.chromium.org/7111012/diff/9001/chrome/app/google_chrome_strings.grd#newcode462>
>> chrome/app/google_chrome_**strings.grd:462: Google Chrome or Google
>> Chrome
>> Frame cannot be updated on account of inconsistent Google Update Group
>> Policy settings. Please contact your administrator for assistance.
>> On 2011/06/08 17:10:39, Glenn Wilson wrote:
>>
>>> This isn't all that useful, because only admins will see this message.
>>>
>>  We
>>
>>> should be explicit on what they need to do, and perhaps provide a URL
>>>
>> they can
>>
>>> go to to resolve the problem.
>>>
>>
>> Are you still volunteering to write a help article for this?  If so,
>> could you send me a URL (goo.gl?) to put in the message?  I'll also put
>> it in the log message.  Thanks.
>
>
> Yes, this is on my TODO list.
>
> I'm thinking this should be hosted on google.com instead of chromium.org,
> although that means it will likely take longer to do, get localized, etc.
>  Are you ok with that kind of delay?
>
> If so, I could provide you with a link to a google help center article.
>
>
Agreed, google.com makes sense.  Could you generate a short URL that I can
include in the messages now?

[Glenn Wilson, 2011-06-13 22:49:49]

Just sent you the doc.  Once we can get it posted in the HC, we can make a
short link (or even use the HC link)

On Mon, Jun 13, 2011 at 7:00 AM, Greg Thompson <grt@chromium.org> wrote:

> On Thu, Jun 9, 2011 at 5:32 PM, Glenn Wilson <gwilson@chromium.org> wrote:
>
>>
>>
>> On Wed, Jun 8, 2011 at 12:42 PM, <grt@chromium.org> wrote:
>>
>>> Thanks for having a look.
>>>
>>>
>>>
>>> http://codereview.chromium.**org/7111012/diff/9001/chrome/**
>>>
app/google_chrome_strings.grd<http://codereview.chromium.org/7111012/diff/9001/chrome/app/google_chrome_strings.grd>
>>> File chrome/app/google_chrome_**strings.grd (right):
>>>
>>> http://codereview.chromium.**org/7111012/diff/9001/chrome/**
>>>
app/google_chrome_strings.grd#**newcode462<http://codereview.chromium.org/7111012/diff/9001/chrome/app/google_chrome_strings.grd#newcode462>
>>> chrome/app/google_chrome_**strings.grd:462: Google Chrome or Google
>>> Chrome
>>> Frame cannot be updated on account of inconsistent Google Update Group
>>> Policy settings. Please contact your administrator for assistance.
>>> On 2011/06/08 17:10:39, Glenn Wilson wrote:
>>>
>>>> This isn't all that useful, because only admins will see this message.
>>>>
>>>  We
>>>
>>>> should be explicit on what they need to do, and perhaps provide a URL
>>>>
>>> they can
>>>
>>>> go to to resolve the problem.
>>>>
>>>
>>> Are you still volunteering to write a help article for this?  If so,
>>> could you send me a URL (goo.gl?) to put in the message?  I'll also put
>>> it in the log message.  Thanks.
>>
>>
>> Yes, this is on my TODO list.
>>
>> I'm thinking this should be hosted on google.com instead of chromium.org,
>> although that means it will likely take longer to do, get localized, etc.
>>  Are you ok with that kind of delay?
>>
>> If so, I could provide you with a link to a google help center article.
>>
>>
> Agreed, google.com makes sense.  Could you generate a short URL that I can
> include in the messages now?

[pastarmovj, 2011-06-15 09:32:22]

LGTM with two small style questions. :)

http://codereview.chromium.org/7111012/diff/9001/chrome/installer/setup/setup...
File chrome/installer/setup/setup_main.cc (right):

http://codereview.chromium.org/7111012/diff/9001/chrome/installer/setup/setup...
chrome/installer/setup/setup_main.cc:292: BrowserDistribution* dist =
(*scan)->distribution();
Can this be const as well? If all the getters below are fine this should be
possible too?

http://codereview.chromium.org/7111012/diff/9001/chrome/installer/setup/setup...
chrome/installer/setup/setup_main.cc:625: proceed_with_installation =
Why not &= instead?

[grt (UTC plus 2), 2011-06-15 13:38:16]

Many thanks.

http://codereview.chromium.org/7111012/diff/9001/chrome/installer/setup/setup...
File chrome/installer/setup/setup_main.cc (right):

http://codereview.chromium.org/7111012/diff/9001/chrome/installer/setup/setup...
chrome/installer/setup/setup_main.cc:292: BrowserDistribution* dist =
(*scan)->distribution();
On 2011/06/15 09:32:22, pastarmovj wrote:
> Can this be const as well? If all the getters below are fine this should be
> possible too?

I wish.  :-)  The BrowserDistribution interface is declared with all non-const
methods.

http://codereview.chromium.org/7111012/diff/9001/chrome/installer/setup/setup...
chrome/installer/setup/setup_main.cc:625: proceed_with_installation =
On 2011/06/15 09:32:22, pastarmovj wrote:
> Why not &= instead?

&= is a bitwise rather than a logical operator.

[pastarmovj, 2011-06-15 13:56:34]

http://codereview.chromium.org/7111012/diff/9001/chrome/installer/setup/setup...
File chrome/installer/setup/setup_main.cc (right):

http://codereview.chromium.org/7111012/diff/9001/chrome/installer/setup/setup...
chrome/installer/setup/setup_main.cc:625: proceed_with_installation =
On 2011/06/15 13:38:16, grt wrote:
> On 2011/06/15 09:32:22, pastarmovj wrote:
> > Why not &= instead?
> 
> &= is a bitwise rather than a logical operator.

True, sorry I must have been half asleep when I wrote that :)

[grt (UTC plus 2), 2011-06-16 03:55:06]

Hi Glenn,

I've updated the error text to make it a bit more specific.  Are you okay with
me landing this change now and updating it with a link to the help center
article once we have the URL?

http://codereview.chromium.org/7111012/diff/20001/chrome/app/google_chrome_st...
File chrome/app/google_chrome_strings.grd (right):

http://codereview.chromium.org/7111012/diff/20001/chrome/app/google_chrome_st...
chrome/app/google_chrome_strings.grd:462: Google Chrome or Google Chrome Frame
cannot be updated on account of inconsistent Google Update Group Policy
settings. Use the Group Policy Editor to set the update policy override for the
Google Chrome Binaries application and try again.
Do you think this new text is useful enough, Glenn?

[Glenn Wilson, 2011-06-16 18:06:06]

lgtm

http://codereview.chromium.org/7111012/diff/20001/chrome/app/google_chrome_st...
File chrome/app/google_chrome_strings.grd (right):

http://codereview.chromium.org/7111012/diff/20001/chrome/app/google_chrome_st...
chrome/app/google_chrome_strings.grd:462: Google Chrome or Google Chrome Frame
cannot be updated on account of inconsistent Google Update Group Policy
settings. Use the Group Policy Editor to set the update policy override for the
Google Chrome Binaries application and try again.
On 2011/06/16 03:55:06, grt wrote:
> Do you think this new text is useful enough, Glenn?

Yes, this seems fine, we'll just add the hyperlink later.

[commit-bot: I haz the power, 2011-06-16 19:51:12]

Change committed as 89384