Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: views/view.cc

Issue 7111008: views: Use ViewVector typedef instead of std::vector<View*> in view.* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/view.cc
diff --git a/views/view.cc b/views/view.cc
index 2c36cc7485ab1d1bb79a33a16313c4a40ea8bb2a..039c70c70839db819c93d040355491dcbc09e7f9 100644
--- a/views/view.cc
+++ b/views/view.cc
@@ -566,7 +566,7 @@ bool View::IsGroupFocusTraversable() const {
return true;
}
-void View::GetViewsWithGroup(int group_id, std::vector<View*>* out) {
+void View::GetViewsWithGroup(int group_id, ViewVector* out) {
if (group_ == group_id)
out->push_back(this);
@@ -575,7 +575,7 @@ void View::GetViewsWithGroup(int group_id, std::vector<View*>* out) {
}
View* View::GetSelectedViewForGroup(int group_id) {
- std::vector<View*> views;
+ ViewVector views;
GetWidget()->GetRootView()->GetViewsWithGroup(group_id, &views);
return views.empty() ? NULL : views[0];
}
@@ -1463,7 +1463,7 @@ void View::BoundsChanged(const gfx::Rect& previous_bounds) {
// Notify interested Views that visible bounds within the root view may have
// changed.
if (descendants_to_notify_.get()) {
- for (std::vector<View*>::iterator i = descendants_to_notify_->begin();
+ for (ViewVector::iterator i = descendants_to_notify_->begin();
i != descendants_to_notify_->end(); ++i) {
(*i)->OnVisibleBoundsChanged();
}
@@ -1744,7 +1744,7 @@ void View::InitFocusSiblings(View* v, int index) {
// the last focusable element. Let's try to find an element with no next
// focusable element to link to.
View* last_focusable_view = NULL;
- for (std::vector<View*>::iterator iter = children_.begin();
+ for (ViewVector::iterator iter = children_.begin();
iter != children_.end(); ++iter) {
if (!(*iter)->next_focusable_view_) {
last_focusable_view = *iter;
« no previous file with comments | « views/view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698