Issue 7109037: views: Make MenuDelegate constructor virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7109037: views: Make MenuDelegate constructor virtual. (Closed)

Created:
9 years, 6 months ago by Nico

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, sky

CC:
chromium-reviews, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

views: Make MenuDelegate constructor virtual. This fixes a real bug, because e.g. chrome/browser/chromeos/frame/browser_view.cc has a scoped_ptr<views::MenuDelegate> that it sets to a SimpleMenuModelDelegateAdapter object. (That class ends up not having a destructor and no non-POD members, so it's just a latent bug.) BUG=84424 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88383

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	views/controls/menu/menu_delegate.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	views/controls/menu/menu_delegate.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 88383

Expand Messages | Collapse Messages