Issue 7109033: file manager: Fix okButton updating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7109033: file manager: Fix okButton updating. (Closed)

Created:
9 years, 6 months ago by rginda

Modified:
9 years, 6 months ago

Reviewers:
achuithb, zel

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

file manager: Fix okButton updating. update the okButton whenever the directory changes. This fixes bug 15845, which was caused by trying to update the button before we had set the current directory, and bug 15464, which was due to the fact that we relied on "Selection changed" events to trigger button updates. BUG=chromium-os:15845, chromium-os:15464 TEST=manual testing on chromeos-chrome on linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87732

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager.js	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

achuithb

9 years, 6 months ago (2011-06-03 20:42:26 UTC) #3

Believe this is causing a js error like
cannot call directoryEntry on undefined
on trunk.

Expand Messages | Collapse Messages