Issue 7109030: Build YASM on Windows using Visual Studio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7109030: Build YASM on Windows using Visual Studio (Closed)

Created:
9 years, 6 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Build YASM on Windows using Visual Studio BUG=70688 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88033

Patch Set 2 : done #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+215 lines, -0 lines)			Patch
A	third_party/yasm/source/config/win/config.h	View	1 chunk	+176 lines, -0 lines	0 comments	Download
A	third_party/yasm/source/config/win/libyasm-stdint.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	third_party/yasm/source/config/win/stdint.h	View	1 chunk	+30 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

LGTM silly MSVC and it's lack of stdint.h http://codereview.chromium.org/7109030/diff/6/third_party/yasm/source/config/win/stdint.h File third_party/yasm/source/config/win/stdint.h (right): http://codereview.chromium.org/7109030/diff/6/third_party/yasm/source/config/win/stdint.h#newcode18 third_party/yasm/source/config/win/stdint.h:18: typedef ...

9 years, 6 months ago (2011-06-06 17:36:44 UTC) #2

Alpha Left Google

9 years, 6 months ago (2011-06-06 19:46:30 UTC) #3

On 2011/06/06 17:36:44, scherkus wrote:
> LGTM
> 
> silly MSVC and it's lack of stdint.h
> 
>
http://codereview.chromium.org/7109030/diff/6/third_party/yasm/source/config/...
> File third_party/yasm/source/config/win/stdint.h (right):
> 
>
http://codereview.chromium.org/7109030/diff/6/third_party/yasm/source/config/...
> third_party/yasm/source/config/win/stdint.h:18: typedef signed long long     
> int64_t;
> is this copied from
>
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/source/in...
> ??
> 
> :)

Yup.

Expand Messages | Collapse Messages

Issue 7109030: Build YASM on Windows using Visual Studio (Closed)

Description

Patch Set 1 #

Patch Set 2 : done #

Messages