[Sync] Ensure cryptographer ready before encrypting.

chrome/browser/sync/util/nigori.cc

Index: chrome/browser/sync/util/nigori.cc
diff --git a/chrome/browser/sync/util/nigori.cc b/chrome/browser/sync/util/nigori.cc
index 0c4418b6ebb813432345158a1b9eebe257a4431e..f8cffca18c34d6dc124b335f132a9d1ea32aa370 100644
--- a/chrome/browser/sync/util/nigori.cc
+++ b/chrome/browser/sync/util/nigori.cc
@@ -168,7 +168,8 @@ std::string GenerateRandomString(size_t size) {
 
 // Enc[Kenc,Kmac](value)
 bool Nigori::Encrypt(const std::string& value, std::string* encrypted) const {
-  DCHECK_LT(0U, value.size());
+  if (0U >= value.size())
+    return false;

[tim (not reviewing), 2011/06/13 17:43:22]

sure we don't want if ... { NOTREACHED(); return false } ?

[Nicolas Zea, 2011/06/13 18:38:22]

I have the NOTREACHED at a higher level (EncryptIfNecessary and
SetPasswordSpecifics). This way, we can still have tests that ensure everything
is handled gracefully.

 
   std::string iv = GenerateRandomString(kIvSize);