Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7108040: Fix text alignment on settings/system page. (Closed)

Created:
9 years, 6 months ago by kevers
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix text alignment on settings/system page. Fixes the vertical alignment of titles on the settings/system page for Chrome OS. Fixed the positioning of slider labels for RTL languages. TEST=Launch Chrome built for Chrome OS. Switch to the settings/system page. Inspect the vertical alignment of titles. Relaunch in Arabic. Check the positioning of the slider labels. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88663

Patch Set 1 #

Total comments: 2

Patch Set 2 : Refactor to remove use of <br>. #

Total comments: 2

Patch Set 3 : Remove blank lines at end of file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -73 lines) Patch
M chrome/browser/resources/options/chromeos/accounts_options_page.css View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/system_options.html View 1 1 chunk +55 lines, -72 lines 0 comments Download
M chrome/browser/resources/options/chromeos/system_options_page.css View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kevers
9 years, 6 months ago (2011-06-09 14:41:09 UTC) #1
James Hawkins
http://codereview.chromium.org/7108040/diff/1/chrome/browser/resources/options/chromeos/system_options.html File chrome/browser/resources/options/chromeos/system_options.html (right): http://codereview.chromium.org/7108040/diff/1/chrome/browser/resources/options/chromeos/system_options.html#newcode14 chrome/browser/resources/options/chromeos/system_options.html:14: <br> Why are you using <br> here?
9 years, 6 months ago (2011-06-09 16:29:12 UTC) #2
kevers
http://codereview.chromium.org/7108040/diff/1/chrome/browser/resources/options/chromeos/system_options.html File chrome/browser/resources/options/chromeos/system_options.html (right): http://codereview.chromium.org/7108040/diff/1/chrome/browser/resources/options/chromeos/system_options.html#newcode14 chrome/browser/resources/options/chromeos/system_options.html:14: <br> On 2011/06/09 16:29:12, James Hawkins wrote: > Why ...
9 years, 6 months ago (2011-06-09 21:58:34 UTC) #3
James Hawkins
LGTM with nit. http://codereview.chromium.org/7108040/diff/4001/chrome/browser/resources/options/chromeos/system_options_page.css File chrome/browser/resources/options/chromeos/system_options_page.css (right): http://codereview.chromium.org/7108040/diff/4001/chrome/browser/resources/options/chromeos/system_options_page.css#newcode25 chrome/browser/resources/options/chromeos/system_options_page.css:25: Remove extra lines at the end.
9 years, 6 months ago (2011-06-09 22:01:11 UTC) #4
Rick Byers
LGTM
9 years, 6 months ago (2011-06-10 02:50:29 UTC) #5
kevers
http://codereview.chromium.org/7108040/diff/4001/chrome/browser/resources/options/chromeos/system_options_page.css File chrome/browser/resources/options/chromeos/system_options_page.css (right): http://codereview.chromium.org/7108040/diff/4001/chrome/browser/resources/options/chromeos/system_options_page.css#newcode25 chrome/browser/resources/options/chromeos/system_options_page.css:25: On 2011/06/09 22:01:12, James Hawkins wrote: > Remove extra ...
9 years, 6 months ago (2011-06-10 12:44:22 UTC) #6
commit-bot: I haz the power
9 years, 6 months ago (2011-06-10 14:50:35 UTC) #7 
Change committed as 88663

Powered by Google App Engine
This is Rietveld 408576698