Adding missing inclusions

Adding missing inclusions


BUG=None
TEST='LoggingTest.*,FileUtilTest.*,PlatformFile.*,StringNumberConversionsTest.*,Time,TimeTicks,TimeDelta'


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89595

[tzik, 2011-06-15 09:38:19]

Hi all.

I found some #include are missing to compile with STLport.
This patch adds them for base/ directory.
Could you review this?

http://codereview.chromium.org/7108033/diff/1/base/file_util.h
File base/file_util.h (right):

http://codereview.chromium.org/7108033/diff/1/base/file_util.h#newcode21
base/file_util.h:21: #include <unistd.h>
for close()

http://codereview.chromium.org/7108033/diff/1/base/logging.h
File base/logging.h (right):

http://codereview.chromium.org/7108033/diff/1/base/logging.h#newcode9
base/logging.h:9: #include <cassert>
#include <cassert> after defining assert may cause compile error with STLport.

http://codereview.chromium.org/7108033/diff/1/base/platform_file_posix.cc
File base/platform_file_posix.cc (right):

http://codereview.chromium.org/7108033/diff/1/base/platform_file_posix.cc#new...
base/platform_file_posix.cc:10: #include <unistd.h>
for close()

http://codereview.chromium.org/7108033/diff/1/base/string_number_conversions.cc
File base/string_number_conversions.cc (right):

http://codereview.chromium.org/7108033/diff/1/base/string_number_conversions....
base/string_number_conversions.cc:9: #include <wctype.h>
for iswspace()

http://codereview.chromium.org/7108033/diff/1/base/test/test_file_util_linux.cc
File base/test/test_file_util_linux.cc (right):

http://codereview.chromium.org/7108033/diff/1/base/test/test_file_util_linux....
base/test/test_file_util_linux.cc:10: #include <unistd.h>
for close()

http://codereview.chromium.org/7108033/diff/1/base/time_posix.cc
File base/time_posix.cc (right):

http://codereview.chromium.org/7108033/diff/1/base/time_posix.cc#newcode9
base/time_posix.cc:9: #include <unistd.h>
for _POSIX_MONOTONIC_CLOCK

[willchan no longer on Chromium, 2011-06-15 11:36:50]

Everything else is great. Just want to double check on this instance.

http://codereview.chromium.org/7108033/diff/1/base/logging.h
File base/logging.h (right):

http://codereview.chromium.org/7108033/diff/1/base/logging.h#newcode9
base/logging.h:9: #include <cassert>
On 2011/06/15 09:38:19, tzik wrote:
> #include <cassert> after defining assert may cause compile error with STLport.

I don't understand how this fix works. Can you explain it? We #undef assert()
here. How will including it up here make this not cause STLport problems? Can
you paste the STLport compile error you're seeing?

[tzik, 2011-06-15 14:06:43]

On 2011/06/15 11:36:50, willchan wrote:
> Everything else is great. Just want to double check on this instance.
> 
> http://codereview.chromium.org/7108033/diff/1/base/logging.h
> File base/logging.h (right):
> 
> http://codereview.chromium.org/7108033/diff/1/base/logging.h#newcode9
> base/logging.h:9: #include <cassert>
> On 2011/06/15 09:38:19, tzik wrote:
> > #include <cassert> after defining assert may cause compile error with
STLport.
> 
> I don't understand how this fix works. Can you explain it? We #undef assert()
> here. How will including it up here make this not cause STLport problems? Can
> you paste the STLport compile error you're seeing?

If assert macro is defined before including assert.h,
STLport failed to include native assert.h.

Error message from STLport is just:
"assert has been defined before inclusion of assert.h header."
Around this #error statement, it says /* see errno.h */.
In errno.h of STLport, it says:
/* If errno has been defined before inclusion of native error.h including it
from STLport errno.h
 * becomes impossible because if:
 * #define errno foo
 * then
 * #include _STLP_NATIVE_C_HEADER(errno.h)
 * becomes:
 * #include _STLP_NATIVE_C_HEADER(foo.h)
 *
 * To fix this problem you have to find where this definition comes from and
include errno.h before it.
 */

[willchan no longer on Chromium, 2011-06-16 10:53:05]

LGTM

On 2011/06/15 14:06:43, tzik wrote:
> On 2011/06/15 11:36:50, willchan wrote:
> > Everything else is great. Just want to double check on this instance.
> > 
> > http://codereview.chromium.org/7108033/diff/1/base/logging.h
> > File base/logging.h (right):
> > 
> > http://codereview.chromium.org/7108033/diff/1/base/logging.h#newcode9
> > base/logging.h:9: #include <cassert>
> > On 2011/06/15 09:38:19, tzik wrote:
> > > #include <cassert> after defining assert may cause compile error with
> STLport.
> > 
> > I don't understand how this fix works. Can you explain it? We #undef
assert()
> > here. How will including it up here make this not cause STLport problems?
Can
> > you paste the STLport compile error you're seeing?
> 
> If assert macro is defined before including assert.h,
> STLport failed to include native assert.h.
> 
> Error message from STLport is just:
> "assert has been defined before inclusion of assert.h header."
> Around this #error statement, it says /* see errno.h */.
> In errno.h of STLport, it says:
> /* If errno has been defined before inclusion of native error.h including it
> from STLport errno.h
>  * becomes impossible because if:
>  * #define errno foo
>  * then
>  * #include _STLP_NATIVE_C_HEADER(errno.h)
>  * becomes:
>  * #include _STLP_NATIVE_C_HEADER(foo.h)
>  *
>  * To fix this problem you have to find where this definition comes from and
> include errno.h before it.
>  */

[commit-bot: I haz the power, 2011-06-18 11:53:19]

Change committed as 89595

[charleshopkins15, 2016-04-27 14:01:00]

charleshopkins15@gmail.com changed reviewers:
+ charleshopkins15@gmail.com