Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6851)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 7108032: Fix crash when swapping in a prerendered page for a page which has an unload handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_manager.cc
diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc
index 09795894aefbc7fa3ed67c45926a1e725b42ddae..9ef807b0ad3046ea84c3b4168ed2ca13e7b79fa3 100644
--- a/chrome/browser/prerender/prerender_manager.cc
+++ b/chrome/browser/prerender/prerender_manager.cc
@@ -80,6 +80,7 @@ class PrerenderManager::OnCloseTabContentsDeleter : public TabContentsDelegate {
}
virtual void CloseContents(TabContents* source) OVERRIDE {
dominich 2011/06/09 01:59:52 if |source| should be |tab_->tab_contents()| here,
cbentzel 2011/06/09 02:08:54 Yes, it should be. Other delegates aren't necessar
+ tab_->tab_contents()->set_delegate(NULL);
dominich 2011/06/09 01:59:52 maybe CHECK that |tab_->tab_contents()| is not NUL
manager_->ScheduleDeleteOldTabContents(tab_.release(), this);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698