this patch adds the manifest proxy server to sel_ldr and the manifest

src/trusted/service_runtime/sel_ldr.h

 /*
  * Copyright (c) 2011 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * NaCl Simple/secure ELF loader (NaCl SEL).
  *
  * This loader can only process NaCl object files as produced using
@@ skipping 56 matching lines @@
                                 } \
                               } while (0)
 #else
 #define WINDOWS_EXCEPTION_TRY do {
 #define WINDOWS_EXCEPTION_CATCH } while (0)
 #endif
 
 struct NaClAppThread;
 struct NaClDesc;  /* see native_client/src/trusted/desc/nacl_desc_base.h */
 struct NaClDynamicRegion;
+struct NaClManifestProxy;
 struct NaClSecureService;
 struct NaClSecureReverseService;
+struct NaClThreadInterface;  /* see sel_ldr_thread_interface.h */
 
 struct NaClDebugCallbacks {
   void (*thread_create_hook)(struct NaClAppThread *natp);
   void (*thread_exit_hook)(struct NaClAppThread *natp);
   void (*process_exit_hook)(int exit_status);
 };
 
 struct NaClApp {
   /*
    * public, user settable prior to app start.
@@ skipping 118 matching lines @@
   int                       threads_launching;
 
   /*
    * Name service must launch after mu, cv, vm_hole_may_exit,
    * threads_launching are initialized.
    */
   struct NaClNameService    *name_service;  /* default name server */
   struct NaClDesc           *name_service_conn_cap;
 
   struct NaClSecureService        *secure_service;
+  struct NaClThread               reverse_setup_thread;
+  /* used only during setup, thread dtors before exiting */
+  struct NaClManifestProxy        *manifest_proxy;
   struct NaClSecureReverseClient  *reverse_client;
   int                             reverse_channel_initialized;
   NaClSrpcChannel                 reverse_channel;
 
   NaClErrorCode             module_load_status;
   int                       module_may_start;
 
   /*
    * runtime info below, thread state, etc; initialized only when app
    * is run.  Mutex mu protects access to mem_map and other member
@@ skipping 299 matching lines @@
 uintptr_t NaClAppVmmapFindMapSpace(struct NaClApp *nap,
                                    int            num_pages);
 
 void NaClCreateServiceSocket(struct NaClApp *nap);
 
 void NaClSendServiceAddressTo(struct NaClApp  *nap,
                               int             desc);
 
 void NaClSecureCommandChannel(struct NaClApp  *nap);
 
+int NaClSecureReverseClientInsertHandler(
+    struct NaClSecureReverseClient *self,
+    void                            (*handler)(
+        void                        *handler_state,

[noelallen_use_chromium, 2011/06/14 02:25:45]

nit: Should these param names be intented to align with '('

[bsy, 2011/06/14 20:30:03]

sure, that would make it more readable and less likely to be confused w/ the
arglist formal arguments.  in general i just tab to the tab stop that aligns
with the rightmost identifier.

+        struct NaClThreadInterface  *thread_if,
+        struct NaClDesc             *new_conn),
+    void                            *handler_state);
+
 NaClErrorCode NaClWaitForLoadModuleStatus(struct NaClApp *nap) NACL_WUR;
 
 NaClErrorCode NaClWaitForStartModuleCommand(struct NaClApp *nap) NACL_WUR;
 
 void NaClFillMemoryRegionWithHalt(void *start, size_t size);
 
 void NaClFillTrampolineRegion(struct NaClApp *nap);
 
 void NaClFillEndOfTextRegion(struct NaClApp *nap);
 
@@ skipping 55 matching lines @@
 
 void NaClVmHoleWaitToStartThread(struct NaClApp *nap);
 
 void NaClVmHoleThreadStackIsSafe(struct NaClApp *nap);
 
 void NaClGdbHook(struct NaClApp const *nap);
 
 EXTERN_C_END
 
 #endif  /* NATIVE_CLIENT_SRC_TRUSTED_SERVICE_RUNTIME_SEL_LDR_H_ */