this patch adds the manifest proxy server to sel_ldr and the manifest

src/trusted/service_runtime/name_service/default_name_service.c

 /*
  * Copyright (c) 2011 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "native_client/src/trusted/service_runtime/name_service/default_name_service.h"
 
+#include "native_client/src/shared/platform/nacl_log.h"

[noelallen_use_chromium, 2011/06/14 02:25:45]

include order?

[bsy, 2011/06/14 20:30:03]

Done.

 #include "native_client/src/trusted/service_runtime/include/sys/fcntl.h"
 #include "native_client/src/trusted/desc/nacl_desc_rng.h"
 
+#include "native_client/src/trusted/manifest_name_service_proxy/manifest_proxy.h"
+#include "native_client/src/trusted/service_runtime/sel_ldr_thread_interface.h"
+
 int NaClDefaultNameServiceInit(struct NaClNameService *ns) {
   /*
    * Create an CSPRNG and enter it into the name server.
    */
-  struct NaClDescRng *rng = NULL;
+  struct NaClDescRng  *rng = NULL;

[noelallen_use_chromium, 2011/06/14 02:25:45]

Did you mean to dbl space here?

[bsy, 2011/06/14 20:30:03]

i use emacs tab to line up identifiers -- this is the consistent style used in
much of the tcb -- and c++ emacs tab stops are set at every two spaces.

 
   rng = (struct NaClDescRng *) malloc(sizeof *rng);
   if (NULL == rng) {
     goto malloc_failed;
   }
   if (!NaClDescRngCtor(rng)) {
     goto rng_ctor_failed;
   }
 
   /*
    * It may appear desirable to insert a factory for rng, so there can
    * be per-thread secure rng access.  However, note that the only way
    * we "transfer" a RNG is to create a new (but indistinguishable)
    * RNG at the recipient, so each lookup results in a new generator
    * anyway.
    */
   (*NACL_VTBL(NaClNameService, ns)->
    CreateDescEntry)(ns,
                     "SecureRandom", NACL_ABI_O_RDWR,
                     (struct NaClDesc *) rng);
-  NaClDescUnref((struct NaClDesc *) rng);
+  rng = NULL;

[noelallen_use_chromium, 2011/06/14 02:25:45]

You immediately return, this is a NOP.

[bsy, 2011/06/14 20:30:03]

i know.  the compiler will also know.  i do similar thing in dtors and other
cleanup functions in case there are more code added later, and sometimes in case
there is an object-reuse (use-after-free) problem.  having the explicit
assignment here (should) make obvious the ownership transfer.

 
   return 1;
 
  rng_ctor_failed:
   free(rng);
  malloc_failed:
   return 0;
 }