Issue 7108025: Add PyAuto automation call GetPanelInfo().

Issue 7108025: Add PyAuto automation call GetPanelInfo(). (Closed)

Created:
9 years, 6 months ago by dtu

Modified:
9 years, 6 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, John Grabowski, kkania, anantha, dyu1, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add PyAuto automation call GetPanelInfo(). Includes basic information: title, url, renderer pid, and whether it is incognito. BUG=chromium-os:14135 TEST=Manual. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88439

Patch Set 1 #

Total comments: 4

Patch Set 2 : nirnimesh. #

Total comments: 1

Patch Set 3 : Comment. #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -0 lines)			Patch
	M	chrome/browser/automation/testing_automation_provider.cc	View		1 chunk	+16 lines, -0 lines	0 comments	Download
	M	chrome/test/pyautolib/pyauto.py	View	1 2	2 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

http://codereview.chromium.org/7108025/diff/1/chrome/test/pyautolib/pyauto.py File chrome/test/pyautolib/pyauto.py (right): http://codereview.chromium.org/7108025/diff/1/chrome/test/pyautolib/pyauto.py#newcode1177 chrome/test/pyautolib/pyauto.py:1177: u'index': 1, Add 'type' here http://codereview.chromium.org/7108025/diff/1/chrome/test/pyautolib/pyauto.py#newcode2946 chrome/test/pyautolib/pyauto.py:2946: for tab ...

9 years, 6 months ago (2011-06-08 21:50:28 UTC) #2

dtu

9 years, 6 months ago (2011-06-08 22:02:57 UTC) #3

Nirnimesh

9 years, 6 months ago (2011-06-08 22:07:22 UTC) #4

LGTM

http://codereview.chromium.org/7108025/diff/5004/chrome/test/pyautolib/pyauto.py
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/7108025/diff/5004/chrome/test/pyautolib/pyauto...
chrome/test/pyautolib/pyauto.py:2923: """Get details about open ChromeOS panels.
Add some notes like:

A panel is actually a specialized window, so all info about it is available in
GetBrowserWindow() as well.

Expand Messages | Collapse Messages