Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7108024: Make selection in omnibox break at periods. (Closed)

Created:
9 years, 6 months ago by Avi (use Gerrit)
Modified:
9 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Make selection in omnibox break at periods. BUG=28145 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88639

Patch Set 1 #

Total comments: 1

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
9 years, 6 months ago (2011-06-08 18:28:52 UTC) #1
Mark Mentovai
LGTM http://codereview.chromium.org/7108024/diff/1/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm File chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm (right): http://codereview.chromium.org/7108024/diff/1/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm#newcode541 chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm:541: range:NSMakeRange(0, [as length])]; Optional: consider computing NSMakeRange(0, [as ...
9 years, 6 months ago (2011-06-09 14:23:05 UTC) #2
Avi (use Gerrit)
Better?
9 years, 6 months ago (2011-06-09 22:00:34 UTC) #3
Mark Mentovai
9 years, 6 months ago (2011-06-09 22:03:02 UTC) #4 
LGTM. Nice range.

Powered by Google App Engine
This is Rietveld 408576698