Fix flakiness in pyauto test on ChromeOS: ntp.NTPTest.testThumbnailPersistence.

chrome/test/pyautolib/pyauto.py

 #!/usr/bin/python
 
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """PyAuto: Python Interface to Chromium's Automation Proxy.
 
 PyAuto uses swig to expose Automation Proxy interfaces to Python.
 For complete documentation on the functionality available,
@@ skipping 153 matching lines @@
       self.UseNamedChannelID(named_channel_id)
     self.SetUp()     # Fire browser
 
     # TODO(dtu): Remove this after crosbug.com/4558 is fixed.
     if self.IsChromeOS():
       self.WaitUntil(lambda: not self.GetNetworkInfo()['offline_mode'])
 
   def tearDown(self):
     self.TearDown()  # Destroy browser
 
-  @staticmethod
-  def CloseChromeOnChromeOS():
+  def CloseChromeOnChromeOS(self):
     """Gracefully exit chrome on ChromeOS."""
+
+    def _GetListOfChromePids():
+      """Retrieves the list of currently-running Chrome process IDs.
+
+      Returns:
+        A list of strings, where each string represents a currently-running
+        'chrome' process ID.
+      """
+      proc = subprocess.Popen(['ps', '-C', 'chrome'], stdout=subprocess.PIPE)

[Nirnimesh, 2011/06/08 18:32:22]

'prep chrome' will be easier to parse

[dennis_jeffrey, 2011/06/08 21:50:31]

Awesome!  Thanks!

+      output, _ = proc.communicate()

[Nirnimesh, 2011/06/08 18:32:22]

output = proc.communicate()[0]

[dennis_jeffrey, 2011/06/08 21:50:31]

This line has since been removed.

+      pids = []
+      for line in output.split('\n'):
+        line = line.strip()
+        if line.find('chrome') >= 0:
+          pids.append(line[:line.find(' ')])
+      return pids
+
+    orig_pids = _GetListOfChromePids()
     subprocess.call(['pkill', 'chrome'])
 
+    def _DoesOldChromeProcessStillExist():

[Nirnimesh, 2011/06/08 18:32:22]

take orig_pids as arg

[dennis_jeffrey, 2011/06/08 21:50:31]

Done.

+      """Determines whether an originally-running 'chrome' process exists.
+
+      Returns:
+        True, if an originally-running 'chrome' process still exists, or
+        False otherwise.
+      """
+      new_pids = _GetListOfChromePids()
+      for new_pid in new_pids:

[Nirnimesh, 2011/06/08 18:32:22]

merge with previous line

[dennis_jeffrey, 2011/06/08 21:50:31]

Done.

+        if new_pid in orig_pids:
+          return True
+      return False
+
+    self.WaitUntil(lambda: not _DoesOldChromeProcessStillExist())

[Nirnimesh, 2011/06/08 18:32:22]

pass orig_pids as arg

[Nirnimesh, 2011/06/08 18:32:22]

Why the negation? Just invert the function --
lambda: _ArePIDsDead(orig_pids)

[dennis_jeffrey, 2011/06/08 21:50:31]

Done.

[dennis_jeffrey, 2011/06/08 21:50:31]

Done.

+
   def EnableChromeTestingOnChromeOS(self):
     """Enables the named automation interface on chromeos.
 
     Restarts chrome so that you get a fresh instance.
     Also sets some testing-friendly flags for chrome.
 
     Expects suid python to be present in the same dir as pyautolib.py
     """
     def _IsRootSuid(path):
       return os.path.isfile(path) and (os.stat(path).st_mode & stat.S_ISUID)
@@ skipping 3435 matching lines @@
     if self._options.verbose:
       verbosity = 2
     result = PyAutoTextTestRuner(verbosity=verbosity).run(pyauto_suite)
     del loaded_tests  # Need to destroy test cases before the suite
     del pyauto_suite
     sys.exit(not result.wasSuccessful())
 
 
 if __name__ == '__main__':
   Main()