Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 7108022: Libcros version-up for preedit text monitoring on ChromeOS. (Closed)

Created:
9 years, 6 months ago by kinaba
Modified:
9 years, 6 months ago
Reviewers:
kochi
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

Libcros version-up for preedit text monitoring on ChromeOS. This is going to be used for fixing crosbug.com/13374, by adding a display area for preedits on a candidate window. This patch is just for updating libcros in Chromium to version 150: http://gerrit.chromium.org/gerrit/2288 BUG=chromium-os:13374 TEST=boot ChromeOS and verify it runs safely. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88640

Patch Set 1 #

Patch Set 2 : Update DEPS file for using http://gerrit.chromium.org/gerrit/2288 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/browser/chromeos/input_method/candidate_window.cc View 4 chunks +23 lines, -0 lines 0 comments Download
M tools/cros.DEPS/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kinaba
9 years, 6 months ago (2011-06-09 09:39:02 UTC) #1
kinaba
kochi-san, could you review this update please?
9 years, 6 months ago (2011-06-10 03:31:25 UTC) #2
kochi
9 years, 6 months ago (2011-06-10 04:12:47 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698