chrome/browser/resources/options/about_page.html - Issue 7108019: Change Chrome OS version numbers to Platform versions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/about_page.html

Issue 7108019: Change Chrome OS version numbers to Platform versions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comment fixes. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/version_loader.h ('K') | « chrome/browser/resources/about_version.html ('k') | chrome/browser/ui/webui/options/about_page_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/about_page.html

diff --git a/chrome/browser/resources/options/about_page.html b/chrome/browser/resources/options/about_page.html

index 05baa8d0c241c5c1522974730b5b36b11af3ede5..74056d26bf9c2da71ed56a5aaa4e95c7e9493f79 100644

--- a/chrome/browser/resources/options/about_page.html

+++ b/chrome/browser/resources/options/about_page.html

@@ -4,14 +4,19 @@

<div>

- <div><span i18n-content="firmware"></span> <span id="osFirmware0">

- <span class="loading" i18n-content="loading"></span></span></div>

- <div><span i18n-content="os"></span> <span id="osVersion0">

- <span class="loading" i18n-content="loading"></span></span></div>

<div>

</div>

+<if expr="not pp_ifdef('chromeos')">

+ <div><span i18n-content="os"></span> <span id="osVersion0">

+</if>

+<if expr="pp_ifdef('chromeos')">

+ <div><span>Platform</span> <span id="osVersion0">

+</if>

+ <span class="loading" i18n-content="loading"></span></span></div>

+ <div><span i18n-content="firmware"></span> <span id="osFirmware0">

+ <span class="loading" i18n-content="loading"></span></span></div>

<div>

<button id="moreInfoButton" class="link-button"

i18n-content="more_info"></button>

@@ -35,19 +40,24 @@

</div>

DaveMoore 2011/06/08 21:10:37 Why has this moved sections?

rkc 2011/06/08 21:39:57 I re-ordered the sections to move the Chrome versi

</section>

- <h3 i18n-content="firmware"></h3>

- <div id="osFirmware1">

- <span class="loading" i18n-content="loading"></span>

+ <h3 i18n-content="browser"></h3>

+ <div i18n-content="browser_version"></div>

</section>

+<if expr="not pp_ifdef('chromeos')">

+</if>

+<if expr="pp_ifdef('chromeos')">

+ <h3>Platform</h3>

+</if>

</div>

</section>

- <h3 i18n-content="browser"></h3>

- <div i18n-content="browser_version"></div>

+ <h3 i18n-content="firmware"></h3>

+ <div id="osFirmware1">

+ <span class="loading" i18n-content="loading"></span>

</section>

<h3>WebKit</h3>