Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: chrome/browser/chromeos/version_loader.h

Issue 7108019: Change Chrome OS version numbers to Platform versions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment fixes. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/version_loader.h
diff --git a/chrome/browser/chromeos/version_loader.h b/chrome/browser/chromeos/version_loader.h
index 219cd3a9058c867f10996181f6e7fe0396353830..172b395d29f437bcd03c11c6e25cfc75ab131c4c 100644
--- a/chrome/browser/chromeos/version_loader.h
+++ b/chrome/browser/chromeos/version_loader.h
@@ -59,6 +59,12 @@ class VersionLoader : public CancelableRequestProvider {
Handle GetFirmware(CancelableRequestConsumerBase* consumer,
GetFirmwareCallback* callback);
+ // Parse the version information as a Chrome platfrom, not Chrome OS
+ // TODO(rkc): Change this and everywhere it is used once we switch Chrome OS
+ // over to xx.yyy.zz version numbers instead of 0.xx.yyy.zz
+ // Refer to http://code.google.com/p/chromium-os/issues/detail?id=15789
+ void EnablePlatformVersions(bool enable);
+
static const char kFullVersionPrefix[];
static const char kVersionPrefix[];
static const char kFirmwarePrefix[];
@@ -72,7 +78,7 @@ class VersionLoader : public CancelableRequestProvider {
// and extract the version.
class Backend : public base::RefCountedThreadSafe<Backend> {
public:
- Backend() {}
+ Backend() : parse_as_platform_(false) {}
// Calls ParseVersion to get the version # and notifies request.
// This is invoked on the file thread.
@@ -84,9 +90,13 @@ class VersionLoader : public CancelableRequestProvider {
// This is invoked on the file thread.
void GetFirmware(scoped_refptr<GetFirmwareRequest> request);
+ void SetPlatformVersions(bool value) { parse_as_platform_ = value; }
DaveMoore 2011/06/08 21:10:37 If this is a simple accessor with an inlined imple
rkc 2011/06/08 21:39:57 Done.
+
private:
friend class base::RefCountedThreadSafe<Backend>;
+ bool parse_as_platform_;
+
~Backend() {}
DISALLOW_COPY_AND_ASSIGN(Backend);

Powered by Google App Engine
This is Rietveld 408576698