Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 7108017: Added Ctrl+Shift+w keyboard shortcut to close a window. (Closed)

Created:
9 years, 6 months ago by shinyak (Google)
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Added Ctrl+Shift+w keyboard shortcut to close a window. BUG=84698 TEST=Open a window and press Ctrl+Shift+w. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/gtk/accelerators_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
shinyak (Google)
Since Chromium on Linux did not accept Ctrl+Shift+W to close window, I've add its keyboard ...
9 years, 6 months ago (2011-06-08 04:20:59 UTC) #1
shinyak (Google)
Ping?
9 years, 6 months ago (2011-06-09 02:09:06 UTC) #2
Evan Stade
seems OK to me, but maybe there is some arcane reason not to do this ...
9 years, 6 months ago (2011-06-09 20:29:37 UTC) #3
Evan Martin
I have no objection, I guess, if we're matching the other platforms. Peter, I've never ...
9 years, 6 months ago (2011-06-09 20:38:59 UTC) #4
Peter Kasting
On 2011/06/09 20:38:59, Evan Martin wrote: > I have no objection, I guess, if we're ...
9 years, 6 months ago (2011-06-09 20:50:50 UTC) #5
Evan Stade
then LGTM -- Evan Stade On Thu, Jun 9, 2011 at 1:50 PM, <pkasting@chromium.org> wrote: ...
9 years, 6 months ago (2011-06-09 20:51:45 UTC) #6
commit-bot: I haz the power
9 years, 6 months ago (2011-06-10 02:50:10 UTC) #7
Change committed as 88632

Powered by Google App Engine
This is Rietveld 408576698