Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7108012: file manager: Prevent [ENTER] from completing the save-as dialog in bad directories (Closed)

Created:
9 years, 6 months ago by rginda
Modified:
9 years, 6 months ago
Reviewers:
achuithb
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

file manager: Prevent [ENTER] from completing the save-as dialog in bad directories Previous code reset the disabled state of the ok button on-keypress of the filename input text box. This overwrote the fact the the ok button may have been disabled because we're in the / or /media directories. BUG=chromium-os:16276 TEST=manual testing on chromeos-chrome in linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88349

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 5 chunks +18 lines, -9 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
rginda
http://codereview.chromium.org/7108012/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (left): http://codereview.chromium.org/7108012/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#oldcode1550 chrome/browser/resources/file_manager/js/file_manager.js:1550: var selectable; This was moved to updateOkButton_, where it ...
9 years, 6 months ago (2011-06-07 23:35:35 UTC) #1
achuithb
9 years, 6 months ago (2011-06-08 01:01:20 UTC) #2
On 2011/06/07 23:35:35, rginda wrote:
>
http://codereview.chromium.org/7108012/diff/1/chrome/browser/resources/file_m...
> File chrome/browser/resources/file_manager/js/file_manager.js (left):
> 
>
http://codereview.chromium.org/7108012/diff/1/chrome/browser/resources/file_m...
> chrome/browser/resources/file_manager/js/file_manager.js:1550: var selectable;
> This was moved to updateOkButton_, where it should have been.
> 
>
http://codereview.chromium.org/7108012/diff/1/chrome/browser/resources/file_m...
> File chrome/browser/resources/file_manager/js/file_manager.js (right):
> 
>
http://codereview.chromium.org/7108012/diff/1/chrome/browser/resources/file_m...
> chrome/browser/resources/file_manager/js/file_manager.js:1553: if
> (this.dialogType_ == FileManager.DialogType.SELECT_SAVEAS_FILE) {
> This snippet came from updateOkButton_.  It was accidentally put there when
> updateOkButton_ was extracted from this function.


Ok. LGTM.

Powered by Google App Engine
This is Rietveld 408576698