Upstream ChromeOS patch on O3D. (Change Icf3bc91d: http://gerrit.chromium.org/gerrit/#change,2220)

Upstream ChromeOS patch on O3D. (Change Icf3bc91d: http://gerrit.chromium.org/gerrit/#change,2220)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88250

[Tristan Schmelcher 2, 2011-06-07 21:31:22]

Rather than duplicating this variable everywhere, please put it in common.gypi.

[zhurunz1, 2011-06-07 23:37:07]

Done. Moved to common.gypi

[Tristan Schmelcher 2, 2011-06-07 23:39:47]

Should include the sqllite change in this CL too and handle it similarly.

http://codereview.chromium.org/7108010/diff/1003/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7108010/diff/1003/build/common.gypi#newcode85
build/common.gypi:85: [ 'OS == "linux" or OS == "freebsd" or OS == "openbsd"', {
No leading space before the ' that starts the string.

[zhurunz1, 2011-06-07 23:58:54]

Done.

http://codereview.chromium.org/7108010/diff/1003/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7108010/diff/1003/build/common.gypi#newcode85
build/common.gypi:85: [ 'OS == "linux" or OS == "freebsd" or OS == "openbsd"', {
On 2011/06/07 23:39:47, Tristan Schmelcher 2 wrote:
> No leading space before the ' that starts the string.

Done.

[Tristan Schmelcher 2, 2011-06-07 23:59:49]

Don't see a new snapshot.

[Tristan Schmelcher 2, 2011-06-08 00:01:12]

LGTM