Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 7108006: The benchmarking tool calculates the population variance rather than the sample variance. Since ... (Closed)

Created:
9 years, 6 months ago by Jon Leighton
Modified:
9 years, 6 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

The benchmarking tool calculates the population variance rather than the sample variance. Since benchmarking results represent only a sample of the entire population of results, it would be better to calculate the sample standard deviation, which is an unbiased estimator of the population variance. Also, since the Array.avg function throws out the min and max, this function should not be used when calculating the variance. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88379

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/common/extensions/docs/examples/extensions/benchmark/options.html View 1 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mike Belshe
9 years, 6 months ago (2011-06-08 18:04:58 UTC) #1
LGTM

Powered by Google App Engine
This is Rietveld 408576698