Issue 7107003: [Linux] Do not install SIGPROF handler until we

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7107003: [Linux] Do not install SIGPROF handler until we (Closed)

Created:
9 years, 6 months ago by mnaganov (inactive)

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

[Linux] Do not install SIGPROF handler until we start CPU profiling. TBR=vitalyr@chromium.org BUG=1344 ,crbug/79320,crbug/83521 TEST=none

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -15 lines)			Patch
	M	src/platform-linux.cc	View		3 chunks	+23 lines, -15 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 6 months ago (2011-06-02 10:26:55 UTC) #1

http://codereview.chromium.org/7107003/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):

http://codereview.chromium.org/7107003/diff/1/src/platform-linux.cc#newcode1031
src/platform-linux.cc:1031: if (cpu_profiling_enabled &&
!signal_handler_installed_)
Drive-by: please use braces around the bodies of if statements. We can just fix
this on bleeding_edge and leave it as is on the branches.

Expand Messages | Collapse Messages