Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1746)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 7105026: Delete the download shelf before we destroy the browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index b184e79976eb2eb60b967db3bf5022f4e9a94be1..646dd9b4514ff10c16a3569e2c797377bf1dfadc 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -948,10 +948,12 @@ void BrowserView::SaveFocusedView() {
}
void BrowserView::DestroyBrowser() {
- // Explicitly delete the BookmarkBarView now. That way we don't have to
- // worry about the BookmarkBarView potentially outliving the Browser &
- // Profile.
+ // Explicitly delete the BookmarkBarView, DownloadShelfView and child views
+ // owned by BrowserView before destroying |browser_|. That way we don't have
+ // to worry about them potentially outliving the Browser & Profile.
bookmark_bar_view_.reset();
+ download_shelf_.reset();
+ RemoveAllChildViews(true);
browser_.reset();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698