Delete the download shelf before we destroy the browser

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #if defined(TOOLKIT_USES_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 934 matching lines @@
   views::View* focused_view = GetFocusManager()->GetFocusedView();
   if (focused_view)
     view_storage->StoreView(last_focused_view_storage_id_, focused_view);
 }
 
 void BrowserView::DestroyBrowser() {
   // Explicitly delete the BookmarkBarView now. That way we don't have to
   // worry about the BookmarkBarView potentially outliving the Browser &
   // Profile.
   bookmark_bar_view_.reset();
+  // Ditto for DownloadShelfView.
+  download_shelf_.reset();

[Ben Goodger (Google), 2011/06/01 20:47:50]

My question is - what other views are there that this might apply to? Are both
of these views not parent owned? Are there any others?

Who calls this?

[asanka, 2011/06/01 21:06:42]

This is called by BrowserList::CloseAllBrowsers(), which can be called while
processing a WM_ENDSESSION message.

The problem here is that DownloadItemView shouldn't outlive the Browser.  On a
more general note, I think the comment in ~BrowserView also applies here:

  // Child views maintain PrefMember attributes that point to
  // OffTheRecordProfile's PrefService which gets deleted by ~Browser.
  RemoveAllChildViews(true);
  // Explicitly set browser_ to NULL.
  browser_.reset();

So perhaps we should RemoveAllChildViews() before we destroy browser_ in
DestroyBrowser().  I'll look and see what else might go wrong when we destroy
the browser_ while the BrowserView is still around.

   browser_.reset();
 }
 
 bool BrowserView::IsBookmarkBarVisible() const {
   return browser_->SupportsWindowFeature(Browser::FEATURE_BOOKMARKBAR) &&
       active_bookmark_bar_ &&
       (active_bookmark_bar_->GetPreferredSize().height() != 0);
 }
 
 bool BrowserView::IsBookmarkBarAnimating() const {
@@ skipping 1636 matching lines @@
   view->GetWindow()->non_client_view()->SetAccessibleName(
       l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
   return view;
 }
 #endif
 
 // static
 FindBar* BrowserWindow::CreateFindBar(Browser* browser) {
   return browser::CreateFindBar(static_cast<BrowserView*>(browser->window()));
 }