Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: chrome/browser/policy/cloud_policy_cache_base.cc

Issue 7105018: UMA metrics for cloud policies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments, rebased Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud_policy_cache_base.cc
diff --git a/chrome/browser/policy/cloud_policy_cache_base.cc b/chrome/browser/policy/cloud_policy_cache_base.cc
index 1bf5c04fc7c68d17cb970ace0d63fe359cf08ad2..f48e537393986cdc51a40e1c9e10c6be3892e031 100644
--- a/chrome/browser/policy/cloud_policy_cache_base.cc
+++ b/chrome/browser/policy/cloud_policy_cache_base.cc
@@ -7,7 +7,9 @@
#include <string>
#include "base/logging.h"
+#include "base/metrics/histogram.h"
#include "base/values.h"
+#include "chrome/browser/policy/enterprise_metrics.h"
#include "chrome/browser/policy/policy_notifier.h"
namespace policy {
@@ -64,6 +66,8 @@ bool CloudPolicyCacheBase::SetPolicyInternal(
&temp_timestamp, &temp_public_key_version);
if (!ok) {
LOG(WARNING) << "Decoding policy data failed.";
+ UMA_HISTOGRAM_ENUMERATION(kMetricPolicy, kMetricPolicyFetchInvalidPolicy,
+ kMetricPolicySize);
return false;
}
if (timestamp) {
@@ -72,6 +76,9 @@ bool CloudPolicyCacheBase::SetPolicyInternal(
if (check_for_timestamp_validity &&
temp_timestamp > base::Time::NowFromSystemTime()) {
LOG(WARNING) << "Rejected policy data, file is from the future.";
+ UMA_HISTOGRAM_ENUMERATION(kMetricPolicy,
+ kMetricPolicyFetchTimestampInFuture,
+ kMetricPolicySize);
return false;
}
public_key_version_.version = temp_public_key_version.version;
@@ -84,6 +91,11 @@ bool CloudPolicyCacheBase::SetPolicyInternal(
recommended_policy_.Swap(&recommended_policy);
initialization_complete_ = true;
+ if (!new_policy_differs) {
+ UMA_HISTOGRAM_ENUMERATION(kMetricPolicy, kMetricPolicyFetchNotModified,
+ kMetricPolicySize);
+ }
+
if (new_policy_differs || initialization_was_not_complete) {
FOR_EACH_OBSERVER(Observer, observer_list_, OnCacheUpdate(this));
}

Powered by Google App Engine
This is Rietveld 408576698