Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: chrome/browser/policy/user_policy_token_cache.cc

Issue 7105018: UMA metrics for cloud policies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments, rebased Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/policy/user_policy_token_cache.h" 5 #include "chrome/browser/policy/user_policy_token_cache.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/metrics/histogram.h"
9 #include "chrome/browser/policy/enterprise_metrics.h"
8 #include "content/browser/browser_thread.h" 10 #include "content/browser/browser_thread.h"
9 11
12 namespace {
13
14 // Other places can sample on the same UMA counter, so make sure they all do
15 // it on the same thread (UI).
16 void SampleUMAOnUIThread(policy::MetricToken sample) {
17 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
18 UMA_HISTOGRAM_ENUMERATION(policy::kMetricToken, sample,
19 policy::kMetricTokenSize);
20 }
21
22 void SampleUMA(policy::MetricToken sample) {
23 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
24 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
25 NewRunnableFunction(&SampleUMAOnUIThread, sample));
26 }
27
28 } // namespace
29
10 namespace policy { 30 namespace policy {
11 31
12 namespace em = enterprise_management; 32 namespace em = enterprise_management;
13 33
14 UserPolicyTokenCache::Delegate::~Delegate() {} 34 UserPolicyTokenCache::Delegate::~Delegate() {}
15 35
16 UserPolicyTokenCache::UserPolicyTokenCache( 36 UserPolicyTokenCache::UserPolicyTokenCache(
17 const base::WeakPtr<Delegate>& delegate, 37 const base::WeakPtr<Delegate>& delegate,
18 const FilePath& cache_file) 38 const FilePath& cache_file)
19 : delegate_(delegate), 39 : delegate_(delegate),
20 cache_file_(cache_file) {} 40 cache_file_(cache_file) {}
21 41
22 void UserPolicyTokenCache::Load() { 42 void UserPolicyTokenCache::Load() {
23 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 43 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
44 UMA_HISTOGRAM_ENUMERATION(kMetricToken, kMetricTokenLoadRequested,
45 kMetricTokenSize);
24 BrowserThread::PostTask( 46 BrowserThread::PostTask(
25 BrowserThread::FILE, FROM_HERE, 47 BrowserThread::FILE, FROM_HERE,
26 NewRunnableMethod(this, &UserPolicyTokenCache::LoadOnFileThread)); 48 NewRunnableMethod(this, &UserPolicyTokenCache::LoadOnFileThread));
27 } 49 }
28 50
29 void UserPolicyTokenCache::Store(const std::string& token, 51 void UserPolicyTokenCache::Store(const std::string& token,
30 const std::string& device_id) { 52 const std::string& device_id) {
31 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 53 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
54 UMA_HISTOGRAM_ENUMERATION(kMetricToken, kMetricTokenStoreRequested,
55 kMetricTokenSize);
32 BrowserThread::PostTask( 56 BrowserThread::PostTask(
33 BrowserThread::FILE, FROM_HERE, 57 BrowserThread::FILE, FROM_HERE,
34 NewRunnableMethod(this, 58 NewRunnableMethod(this,
35 &UserPolicyTokenCache::StoreOnFileThread, 59 &UserPolicyTokenCache::StoreOnFileThread,
36 token, 60 token,
37 device_id)); 61 device_id));
38 } 62 }
39 63
40 UserPolicyTokenCache::~UserPolicyTokenCache() { 64 UserPolicyTokenCache::~UserPolicyTokenCache() {
41 } 65 }
42 66
43 void UserPolicyTokenCache::LoadOnFileThread() { 67 void UserPolicyTokenCache::LoadOnFileThread() {
44 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); 68 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
45 std::string device_token; 69 std::string device_token;
46 std::string device_id; 70 std::string device_id;
47 71
48 if (file_util::PathExists(cache_file_)) { 72 if (file_util::PathExists(cache_file_)) {
49 std::string data; 73 std::string data;
50 em::DeviceCredentials device_credentials; 74 em::DeviceCredentials device_credentials;
51 if (file_util::ReadFileToString(cache_file_, &data) && 75 if (file_util::ReadFileToString(cache_file_, &data) &&
52 device_credentials.ParseFromArray(data.c_str(), data.size())) { 76 device_credentials.ParseFromArray(data.c_str(), data.size())) {
53 device_token = device_credentials.device_token(); 77 device_token = device_credentials.device_token();
54 device_id = device_credentials.device_id(); 78 device_id = device_credentials.device_id();
79 } else {
80 SampleUMA(kMetricTokenLoadFailed);
55 } 81 }
56 } 82 }
57 83
58 BrowserThread::PostTask( 84 BrowserThread::PostTask(
59 BrowserThread::UI, FROM_HERE, 85 BrowserThread::UI, FROM_HERE,
60 NewRunnableMethod(this, 86 NewRunnableMethod(this,
61 &UserPolicyTokenCache::NotifyOnUIThread, 87 &UserPolicyTokenCache::NotifyOnUIThread,
62 device_token, 88 device_token,
63 device_id)); 89 device_id));
64 } 90 }
65 91
66 void UserPolicyTokenCache::NotifyOnUIThread(const std::string& token, 92 void UserPolicyTokenCache::NotifyOnUIThread(const std::string& token,
67 const std::string& device_id) { 93 const std::string& device_id) {
68 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 94 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
69 if (delegate_.get()) 95 if (delegate_.get())
70 delegate_->OnTokenCacheLoaded(token, device_id); 96 delegate_->OnTokenCacheLoaded(token, device_id);
71 } 97 }
72 98
73 void UserPolicyTokenCache::StoreOnFileThread(const std::string& token, 99 void UserPolicyTokenCache::StoreOnFileThread(const std::string& token,
74 const std::string& device_id) { 100 const std::string& device_id) {
75 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); 101 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
76 em::DeviceCredentials device_credentials; 102 em::DeviceCredentials device_credentials;
77 device_credentials.set_device_token(token); 103 device_credentials.set_device_token(token);
78 device_credentials.set_device_id(device_id); 104 device_credentials.set_device_id(device_id);
79 std::string data; 105 std::string data;
80 bool success = device_credentials.SerializeToString(&data); 106 bool success = device_credentials.SerializeToString(&data);
81 if (!success) { 107 if (!success) {
82 LOG(WARNING) << "Failed serialize device token data, will not write " 108 LOG(WARNING) << "Failed serialize device token data, will not write "
83 << cache_file_.value(); 109 << cache_file_.value();
110 SampleUMA(kMetricTokenStoreFailed);
84 return; 111 return;
85 } 112 }
86 113
87 if (!file_util::CreateDirectory(cache_file_.DirName())) { 114 if (!file_util::CreateDirectory(cache_file_.DirName())) {
88 LOG(WARNING) << "Failed to create directory " 115 LOG(WARNING) << "Failed to create directory "
89 << cache_file_.DirName().value(); 116 << cache_file_.DirName().value();
117 SampleUMA(kMetricTokenStoreFailed);
90 return; 118 return;
91 } 119 }
92 120
93 file_util::WriteFile(cache_file_, data.c_str(), data.length()); 121 int size = data.size();
122 if (file_util::WriteFile(cache_file_, data.c_str(), size) != size) {
123 LOG(WARNING) << "Failed to write " << cache_file_.value();
124 SampleUMA(kMetricTokenStoreFailed);
125 }
94 } 126 }
95 127
96 } // namespace policy 128 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698