UMA metrics for cloud policies.

chrome/browser/policy/enterprise_metrics.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_POLICY_ENTERPRISE_METRICS_H_
+#define CHROME_BROWSER_POLICY_ENTERPRISE_METRICS_H_
+#pragma once
+
+namespace enterprise_management {

[gfeher, 2011/06/28 09:58:58]

This namespace is so far only used for protobuf generated classes, and I think
it would be nice to keep it so.

I suggest using the policy namespace and one the following two (your choice):
1. adding a sub-namespace, like in policy_constants.h
2. adding a common prefix to each enum item, e.g. kMetricTokenLoadFailed, etc.
like in out/Debug/.../configuration_policy_type.h

[Joao da Silva, 2011/06/30 12:57:00]

Agree, refactored as per your second suggestion.

+
+// Defines the metrics collected for enterprise events, and provides
+// functions to collect them.
+
+enum TokenOperationResult {
+  kTokenLoadRequested = 0,
+  kTokenLoadFailed,

[kmixter1, 2011/06/28 01:06:02]

If not here, somewhere, it would be good to comment on exactly what this count
signifies.  Some are self-explanatory - though mentioning it applies to both
device and user policies could be helpful.  Probably the most discoverable place
to do it would be the histogram description xml file - though there's only one
comment for each of these three histograms... so maybe the specific comments on
the enumerated values should live here.

[Joao da Silva, 2011/06/30 12:57:00]

I've added a comment to each count, explaining when it is triggered.
histograms.xml has a section after the histograms mapping names to each enum
value, so we can add descriptive names there too.

+
+  kTokenFetchRequested,
+  kTokenFetchRequestFailed,
+  kTokenFetchServerFailed,
+  kTokenFetchResponseReceived,
+  kTokenFetchBadResponse,
+  kTokenFetchManagementNotSupported,
+  kTokenFetchDeviceNotFound,
+  kTokenFetchOK,
+
+  kTokenStoreRequested,
+  kTokenStoreFailed,
+
+  kTokenOperationsSize  // Must be the last.
+};
+
+enum PolicyOperationResult {
+  kPolicyLoadRequested = 0,
+  kPolicyLoadFailed,
+
+  kPolicyFetchRequested,
+  kPolicyFetchRequestFailed,
+  kPolicyFetchServerFailed,
+  kPolicyFetchNotFound,
+  kPolicyFetchResponseReceived,
+  kPolicyFetchBadResponse,
+  kPolicyFetchInvalidToken,
+  kPolicyFetchInvalidPolicy,
+  kPolicyFetchBadSignature,
+  kPolicyFetchTimestampInFuture,
+  kPolicyFetchNonEnterpriseDevice,
+  kPolicyFetchUserMismatch,
+  kPolicyFetchOtherFailed,
+  kPolicyFetchOK,
+  kPolicyFetchNotModified,
+
+  kPolicyStoreRequested,
+  kPolicyStoreFailed,
+
+  kPolicyOperationsSize  // Must be the last.
+};
+
+enum EnrollmentResult {
+  kEnrollmentShowScreen = 0,
+  kEnrollmentCancelled,
+  kEnrollmentStarted,
+  kEnrollmentNetworkFailed,
+  kEnrollmentLoginFailed,
+  kEnrollmentNotSupported,
+  kEnrollmentPolicyFailed,
+  kEnrollmentOtherFailed,
+  kEnrollmentOK,
+
+  kEnrollmentOperationsSize  // Must be the last.
+};
+
+void LogTokenOperation(TokenOperationResult result);
+
+void LogPolicyOperation(PolicyOperationResult result);
+
+void LogEnrollmentOperation(EnrollmentResult result);
+
+}  // namespace enterprise_management
+
+#endif  // CHROME_BROWSER_POLICY_ENTERPRISE_METRICS_H_