Issue 7105016: Ensure strings are never externalized as a side-effect of doing a GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7105016: Ensure strings are never externalized as a side-effect of doing a GC. (Closed)

Created:
9 years, 6 months ago by sandholm

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Ensure strings are never externalized as a side-effect of doing a GC.

Patch Set 1 #

Total comments: 4

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -1 line)			Patch
M	src/api.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/heap.h	View	2 chunks	+4 lines, -0 lines	4 comments	Download
M	src/heap.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM with comments addressed http://codereview.chromium.org/7105016/diff/1/src/heap.h File src/heap.h (right): http://codereview.chromium.org/7105016/diff/1/src/heap.h#newcode1057 src/heap.h:1057: inline int gc_post_process_count() { return ...

9 years, 6 months ago (2011-06-01 11:12:35 UTC) #2

sandholm

http://codereview.chromium.org/7105016/diff/1/src/heap.h File src/heap.h (right): http://codereview.chromium.org/7105016/diff/1/src/heap.h#newcode1057 src/heap.h:1057: inline int gc_post_process_count() { return gc_post_process_count_; } On 2011/06/01 ...

9 years, 6 months ago (2011-06-01 11:39:34 UTC) #3

LGTM with Slava's comments.

Expand Messages | Collapse Messages