Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 7105013: Convert more interfaces to the new thunk system. This goes up to and including (Closed)

Created:
9 years, 6 months ago by brettw
Modified:
9 years, 6 months ago
Reviewers:
Lei Zhang, piman
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Convert more interfaces to the new thunk system. This goes up to and including the ones starting with "F". Since this adds a lot more interfaces, I added the macro stuff we used for the old system to generate the various template specializations. This involded a lot of renaming since the As* needs to match the name (I was previously leaving off the "PPB_" part). I did other misc cleanup to the infrastructure. Review URL: http://codereview.chromium.org/7082036 Reland 87415 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87444

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+970 lines, -1185 lines) Patch
M ppapi/ppapi_shared.gypi View 2 chunks +17 lines, -0 lines 0 comments Download
A + ppapi/proxy/enter_proxy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M ppapi/proxy/interface_id.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_audio_config_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M ppapi/proxy/ppb_broker_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_buffer_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_char_set_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_char_set_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_cursor_control_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_cursor_control_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_file_chooser_proxy.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_file_chooser_proxy.cc View 6 chunks +69 lines, -78 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.cc View 10 chunks +123 lines, -168 lines 0 comments Download
M ppapi/proxy/ppb_file_system_proxy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_file_system_proxy.cc View 6 chunks +76 lines, -74 lines 0 comments Download
M ppapi/proxy/ppb_font_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_font_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_graphics_2d_proxy.h View 3 chunks +4 lines, -55 lines 0 comments Download
M ppapi/proxy/ppb_graphics_2d_proxy.cc View 8 chunks +82 lines, -25 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 2 chunks +10 lines, -1 line 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 4 chunks +35 lines, -15 lines 0 comments Download
M ppapi/shared_impl/audio_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/audio_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/function_group_base.h View 1 chunk +31 lines, -35 lines 0 comments Download
A + ppapi/shared_impl/function_group_base.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M ppapi/shared_impl/resource_object_base.h View 1 chunk +41 lines, -49 lines 0 comments Download
A + ppapi/shared_impl/resource_object_base.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M ppapi/shared_impl/tracker_base.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/thunk/enter.h View 2 chunks +16 lines, -0 lines 0 comments Download
A + ppapi/thunk/ppb_directory_reader_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_directory_reader_thunk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_file_chooser_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_file_chooser_thunk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_file_io_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_file_io_thunk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_file_io_trusted_thunk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_file_ref_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_file_ref_thunk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_file_system_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_file_system_thunk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_find_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/thunk/ppb_find_thunk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 2 chunks +11 lines, -0 lines 0 comments Download
M ppapi/thunk/thunk.h View 2 chunks +14 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 2 chunks +0 lines, -33 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_broker_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_broker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_buffer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_buffer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_char_set_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_char_set_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_cursor_control_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_cursor_control_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_directory_reader_impl.h View 2 chunks +13 lines, -8 lines 0 comments Download
M webkit/plugins/ppapi/ppb_directory_reader_impl.cc View 8 chunks +22 lines, -37 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_chooser_impl.h View 3 chunks +11 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_chooser_impl.cc View 5 chunks +22 lines, -53 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_io_impl.h View 2 chunks +33 lines, -39 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_io_impl.cc View 3 chunks +19 lines, -163 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.h View 4 chunks +26 lines, -14 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.cc View 6 chunks +122 lines, -213 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_system_impl.h View 2 chunks +15 lines, -8 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_system_impl.cc View 2 chunks +34 lines, -58 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_find_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_find_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/plugins/ppapi/ppb_font_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_font_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_image_data_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_image_data_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 2 chunks +10 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 3 chunks +32 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_tracker.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/resource_tracker.cc View 1 2 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
TBR, I broke the PDF test on the official waterfall due to PPB_Find not being ...
9 years, 6 months ago (2011-06-01 07:10:17 UTC) #1
piman
LGTM
9 years, 6 months ago (2011-06-01 07:11:30 UTC) #2
Lei Zhang
FYI, I think M13 got cut after your 1st attempt at this CL, but before ...
9 years, 6 months ago (2011-06-02 21:39:59 UTC) #3
brettw
On Thu, Jun 2, 2011 at 2:39 PM, <thestig@chromium.org> wrote: > FYI, I think M13 ...
9 years, 6 months ago (2011-06-02 23:29:40 UTC) #4
brettw
9 years, 6 months ago (2011-06-02 23:58:12 UTC) #5
On Thu, Jun 2, 2011 at 4:29 PM, Brett Wilson <brettw@chromium.org> wrote:
> On Thu, Jun 2, 2011 at 2:39 PM,  <thestig@chromium.org> wrote:
>> FYI, I think M13 got cut after your 1st attempt at this CL, but before my
>> revert
>> and this second attempt. You may want to merge this to M13.
>
> Thanks for the heads up. This is mostly a code hygiene thing so it
> doesn't really matter when it goes in.

I misread your email and I see what you mean now. Looks like John
merged the fix.

Brett

Powered by Google App Engine
This is Rietveld 408576698