Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 7105002: Re-landing http://codereview.chromium.org/7014019. (Closed)

Created:
9 years, 6 months ago by Nebojša Ćirić
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Re-landing http://codereview.chromium.org/7014019. Adding DateTimeFormat class to i18n API with following methods: - format - getWeekdays - getMonths - get Eras - getAmPm Difference from the reverted revision: Removed all references to v8/src, like ASSERT_EQ. All #includes have full path to include/v8.h or extension headers. TEST=Visit i18n.kaziprst.org/datetimeformat.html Committed: http://code.google.com/p/v8/source/detail?r=8151

Patch Set 1 #

Patch Set 2 : Removing v8/src deps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -12 lines) Patch
A src/extensions/experimental/datetime-format.h View 1 1 chunk +83 lines, -0 lines 0 comments Download
A src/extensions/experimental/datetime-format.cc View 1 1 chunk +384 lines, -0 lines 0 comments Download
M src/extensions/experimental/experimental.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/extensions/experimental/i18n.js View 1 7 chunks +104 lines, -11 lines 0 comments Download
M src/extensions/experimental/i18n-extension.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/extensions/experimental/i18n-utils.h View 1 2 chunks +14 lines, -1 line 0 comments Download
M src/extensions/experimental/i18n-utils.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nebojša Ćirić
Last round of chromium component build fixes. I've uploaded the old revision first to make ...
9 years, 6 months ago (2011-05-31 21:28:07 UTC) #1
Evan Martin
On 2011/05/31 21:28:07, Nebojša Ćirić wrote: > Last round of chromium component build fixes. > ...
9 years, 6 months ago (2011-05-31 21:30:04 UTC) #2
Evan Martin
This otherwise looks good to me, but I am not a v8 master. :)
9 years, 6 months ago (2011-05-31 21:30:55 UTC) #3
Nebojša Ćirić
Done. On 2011/05/31 21:30:04, Evan Martin wrote: > On 2011/05/31 21:28:07, Nebojša Ćirić wrote: > ...
9 years, 6 months ago (2011-05-31 21:33:19 UTC) #4
Mads Ager (chromium)
9 years, 6 months ago (2011-06-01 06:57:46 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698