Issue 7105001: Ellide by fading

Issue 7105001: Ellide by fading (Closed)

Created:
9 years, 6 months ago by davemoore (google)

Modified:
9 years, 6 months ago

Reviewers:
Dmitry Polukhin, oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Ellide by fading BUG=chromium-os:15552 TEST=Examine tabs when text overflows

Patch Set 1 #

Total comments: 4

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -18 lines)			Patch
	M	chrome/browser/ui/views/tabs/tab.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ui/gfx/canvas_skia_linux.cc	View		4 chunks	+81 lines, -17 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

oshima

LGTM with nits. Thank you this change, i'd love it! http://codereview.chromium.org/7105001/diff/1/ui/gfx/canvas_skia_linux.cc File ui/gfx/canvas_skia_linux.cc (right): http://codereview.chromium.org/7105001/diff/1/ui/gfx/canvas_skia_linux.cc#newcode14 ...

9 years, 6 months ago (2011-05-31 23:56:10 UTC) #2

Dmitry Polukhin

http://codereview.chromium.org/7105001/diff/1/ui/gfx/canvas_skia_linux.cc File ui/gfx/canvas_skia_linux.cc (right): http://codereview.chromium.org/7105001/diff/1/ui/gfx/canvas_skia_linux.cc#newcode139 ui/gfx/canvas_skia_linux.cc:139: pango_layout_set_width(layout, -1); Setting width to -1 breaks TEXT_ALIGN_CENTER. See ...

9 years, 6 months ago (2011-06-08 12:50:35 UTC) #3

Dmitry Polukhin

9 years, 6 months ago (2011-06-08 13:09:48 UTC) #4

http://codereview.chromium.org/7105001/diff/1/ui/gfx/canvas_skia_linux.cc
File ui/gfx/canvas_skia_linux.cc (right):

http://codereview.chromium.org/7105001/diff/1/ui/gfx/canvas_skia_linux.cc#new...
ui/gfx/canvas_skia_linux.cc:139: pango_layout_set_width(layout, -1);
On 2011/06/08 12:50:35, Dmitry Polukhin wrote:
> Setting width to -1 breaks TEXT_ALIGN_CENTER. See
> http://code.google.com/p/chromium-os/issues/detail?id=16286. I can add
> NO_ELLIPSIS but it looks broken to me that TEXT_ALIGN_CENTER doesn't work
> without NO_ELLIPSIS. Moreover it looks like later in DrawStringContext::Draw
you
> have condition if text fits to bounds. What about removing this line?

It looks like we can't disable wrap without setting width to -1. But still
requirement to use TEXT_ALIGN_CENTER only with NO_ELLIPSIS in LTR mode looks odd
to me.

Expand Messages | Collapse Messages