Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 7104144: Get rid of the following dependencies from content: (Closed)

Created:
9 years, 6 months ago by jam
Modified:
9 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, brettw-cc_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Get rid of the following dependencies from content: chrome/common/chrome_constants.h chrome/common/chrome_paths.h chrome/common/logging_chrome.h BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88935

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -89 lines) Patch
M chrome/app/chrome_main.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_constants.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 2 5 chunks +29 lines, -0 lines 0 comments Download
M content/browser/DEPS View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/browser_child_process_host.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/plugin_process_host.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/plugin_service.cc View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/backing_store_manager.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/browser_render_process_host.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/site_instance_unittest.cc View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/tab_contents/navigation_entry.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/zygote_host_linux.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
content/browser/zygote_main_linux.cc View 1 2 3 chunks +0 lines, -9 lines 0 comments Download
M content/common/content_constants.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/content_constants.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/content_renderer_client.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/content_renderer_client.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_process.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_process_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_process_impl.cc View 1 2 3 chunks +0 lines, -22 lines 0 comments Download
M content/renderer/render_thread.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 6 months ago (2011-06-13 21:34:01 UTC) #1
Avi (use Gerrit)
9 years, 6 months ago (2011-06-13 21:37:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698