Issue 7104141: Use tuple everywhere with explicit conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7104141: Use tuple everywhere with explicit conversion. (Closed)

Created:
9 years, 6 months ago by M-A Ruel

Modified:
9 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Use tuple everywhere with explicit conversion. TEST=Add PanProjectChecks unittest, there was none. R=dpranke@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88982

Patch Set 2 : fix tuple #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -5 lines)			Patch
	M	presubmit_canned_checks.py	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		3 chunks	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

LGTM. http://codereview.chromium.org/7104141/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): http://codereview.chromium.org/7104141/diff/1/presubmit_canned_checks.py#newcode579 presubmit_canned_checks.py:579: white_list = tuple(white_list or ('.*\.py$')) I think you'll ...

9 years, 6 months ago (2011-06-14 06:28:21 UTC) #2

M-A Ruel

9 years, 6 months ago (2011-06-14 13:05:33 UTC) #3

http://codereview.chromium.org/7104141/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/7104141/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:579: white_list = tuple(white_list or ('.*\.py$'))
On 2011/06/14 06:28:22, Dirk Pranke wrote:
> I think you'll want a trailing comma here: ('.*\.py$',)

Oops indeed, fixed.

Expand Messages | Collapse Messages

Issue 7104141: Use tuple everywhere with explicit conversion. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix tuple #

Messages