chrome/browser/resources/options/search_engine_manager_engine_list.js - Issue 7104121: Add (uneditable) display of extension keywords to the search engine manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 7104121: Add (uneditable) display of extension keywords to the search engine manager. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Catch up with base namespace for values. Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/search_engine_manager.js ('k') | chrome/browser/ui/webui/options/search_engine_manager_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/search_engine_manager_engine_list.js

diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js

index 0a86b5618e81c08f98e591e4888dbe2ebfbad925..4f4b836e2768364d7099267e08ba4a38e68f14b2 100644

--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js

+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js

@@ -160,9 +160,13 @@ cr.define('options.search_engines', function() {

}

// Listen for edit events.

- this.addEventListener('edit', this.onEditStarted_.bind(this));

- this.addEventListener('canceledit', this.onEditCancelled_.bind(this));

- this.addEventListener('commitedit', this.onEditCommitted_.bind(this));

+ if (engine['canBeEdited']) {

+ this.addEventListener('edit', this.onEditStarted_.bind(this));

+ this.addEventListener('canceledit', this.onEditCancelled_.bind(this));

+ this.addEventListener('commitedit', this.onEditCommitted_.bind(this));

+ } else {

+ this.editable = false;

+ }

/** @inheritDoc */