Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: webkit/build/webkit_version.py

Issue 7104106: Unify the version string to be displayed on "About Chromium" dialog. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Update how to construct webkit_url Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/tools/build/win/version.rules ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/build/webkit_version.py
diff --git a/webkit/build/webkit_version.py b/webkit/build/webkit_version.py
index c365b1875ddd7d48d95e8c84270e11fab4f76147..fe9233898b01a9d39f7c4e7b7ad307a6d727aa9e 100755
--- a/webkit/build/webkit_version.py
+++ b/webkit/build/webkit_version.py
@@ -60,20 +60,14 @@ def GetWebKitRevision(webkit_dir, version_file):
default_lastchange=None,
directory=os.path.join(webkit_dir, version_file_dir))
- if (version_info.url.startswith(version_info.root) and
- version_info.url.endswith(version_file_dir)):
- # Now compute the real WebKit URL by stripping off the version file
- # directory from the URL we get out of version_info.
- # Further, we want to strip off the "http://svn..." from the left.
- # This is the root URL from the repository.
- webkit_url = version_info.url[len(version_info.root):-len(version_file_dir)]
- webkit_url = webkit_url.strip('/')
- else:
- # The data isn't as we expect: perhaps they're using git without svn?
- # Just dump the output directly.
- webkit_url = version_info.url
-
- return "%s@%s" % (webkit_url, version_info.revision)
+ if version_info.url == None:
+ version_info.url = 'Unknown URL'
+ version_info.url = version_info.url.strip('/')
+
+ if version_info.revision == None:
+ version_info.revision = '0'
+
+ return "%s@%s" % (version_info.url, version_info.revision)
def EmitVersionHeader(webkit_dir, version_file, output_dir):
@@ -107,5 +101,3 @@ def main():
if __name__ == "__main__":
main()
-
-
« no previous file with comments | « chrome/tools/build/win/version.rules ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698