Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/common/chrome_version_info.cc

Issue 7104106: Unify the version string to be displayed on "About Chromium" dialog. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Update how to construct webkit_url Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_version_info.h ('k') | chrome/tools/build/mac/tweak_info_plist » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_version_info.cc
diff --git a/chrome/common/chrome_version_info.cc b/chrome/common/chrome_version_info.cc
index c5a7a4311b97e23e736303ad642b9082a92ad0df..4e5d1f07389229ac8c174c817ed7007854861d7b 100644
--- a/chrome/common/chrome_version_info.cc
+++ b/chrome/common/chrome_version_info.cc
@@ -7,10 +7,11 @@
#include "base/basictypes.h"
#include "base/file_version_info.h"
#include "base/string_util.h"
-#include "ui/base/l10n/l10n_util.h"
#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "grit/chromium_strings.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
namespace chrome {
@@ -89,11 +90,31 @@ bool VersionInfo::IsOfficialBuild() const {
#endif
+std::string VersionInfo::CreateVersionString() const {
+ std::string current_version;
+ if (is_valid()) {
+ current_version += Version();
+#if !defined(GOOGLE_CHROME_BUILD)
+ current_version += " (";
+ current_version += l10n_util::GetStringUTF8(IDS_ABOUT_VERSION_UNOFFICIAL);
+ current_version += " ";
+ current_version += LastChange();
+ current_version += " ";
+ current_version += OSType();
+ current_version += ")";
+#endif
+ std::string modifier = GetVersionStringModifier();
+ if (!modifier.empty())
+ current_version += " " + modifier;
+ }
+ return current_version;
+}
+
std::string VersionInfo::OSType() const {
#if defined(OS_WIN)
return "Windows";
#elif defined(OS_MACOSX)
- return "Mac OS";
+ return "Mac OS X";
#elif defined(OS_CHROMEOS)
return UTF16ToASCII(l10n_util::GetStringUTF16(IDS_PRODUCT_OS_NAME));
#elif defined(OS_LINUX)
« no previous file with comments | « chrome/common/chrome_version_info.h ('k') | chrome/tools/build/mac/tweak_info_plist » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698