Unify the version string to be displayed on "About Chromium" dialog.

chrome/common/chrome_version_info.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_version_info.h"
 
 #include "base/basictypes.h"
 #include "base/file_version_info.h"
 #include "base/string_util.h"
-#include "ui/base/l10n/l10n_util.h"
 #include "base/threading/thread_restrictions.h"
 #include "build/build_config.h"
 #include "grit/chromium_strings.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
 
 namespace chrome {
 
 #if defined(OS_WIN) || defined(OS_MACOSX)
 // On Windows and Mac, we get the Chrome version info by querying
 // FileVersionInfo for the current module.
 
 VersionInfo::VersionInfo() {
   // The current module is already loaded in memory, so this will be cheap.
   base::ThreadRestrictions::ScopedAllowIO allow_io;
@@ skipping 58 matching lines @@
 std::string VersionInfo::LastChange() const {
   return LAST_CHANGE;
 }
 
 bool VersionInfo::IsOfficialBuild() const {
   return OFFICIAL_BUILD;
 }
 
 #endif
 
+std::string VersionInfo::CreateVersionString() const {
+  std::string current_version = "";

[Mark Mentovai, 2011/07/18 02:20:17]

You don’t need the |= ""| here, get rid of it. The default constructor for a
std::string gives you an empty string, that’s fine.

[haraken1, 2011/07/19 04:36:35]

Done.

+  if (is_valid()) {
+    current_version += Version();
+#if !defined(GOOGLE_CHROME_BUILD)
+    current_version += " (";
+    current_version += l10n_util::GetStringUTF8(IDS_ABOUT_VERSION_UNOFFICIAL);
+    current_version += " ";
+    current_version += OSType();

[Mark Mentovai, 2011/07/18 02:20:17]

OK, so this will be

Developer Build Windows 12345

but I think the order should be

Developer Build 12345 Windows

or

Windows Developer Build 12345

[haraken1, 2011/07/19 04:36:35]

I changed it to

(Developer Build 12345 Windows)



On 2011/07/18 02:20:17, Mark Mentovai wrote:

+    current_version += " ";
+    current_version += LastChange();
+    current_version += ")";
+#endif
+    std::string modifier = GetVersionStringModifier();
+    if (!modifier.empty())
+      current_version += " " + modifier;
+  }
+  return current_version;
+}
+
 std::string VersionInfo::OSType() const {
 #if defined(OS_WIN)
   return "Windows";
 #elif defined(OS_MACOSX)
   return "Mac OS";

[Mark Mentovai, 2011/07/18 02:20:17]

If we’re going to use this, it should be Mac OS X.

But when you change this, make sure that nobody else is currently using it on
the Mac and relying on a specific value.

[haraken1, 2011/07/19 04:36:35]

Changed to "Mac OS X". I confirmed that no place is depending on the specific
value. 

On 2011/07/18 02:20:17, Mark Mentovai wrote:

 #elif defined(OS_CHROMEOS)
   return UTF16ToASCII(l10n_util::GetStringUTF16(IDS_PRODUCT_OS_NAME));
 #elif defined(OS_LINUX)
   return "Linux";
 #elif defined(OS_FREEBSD)
   return "FreeBSD";
 #elif defined(OS_OPENBSD)
   return "OpenBSD";
 #elif defined(OS_SOLARIS)
   return "Solaris";
 #else
   return "Unknown";
 #endif
 }
 
 }  // namespace chrome