Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: chrome/browser/sync/protocol/typed_url_specifics.proto

Issue 7104088: Changed typed url sync to no longer modify typed/visit_count. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated per review comments. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/protocol/proto_value_conversions.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/protocol/typed_url_specifics.proto
diff --git a/chrome/browser/sync/protocol/typed_url_specifics.proto b/chrome/browser/sync/protocol/typed_url_specifics.proto
index 8127fbc6d32497af67f92cfee4c8ed5608f850e1..4bc93e301a76543ed3abdf1a4a0b781e19d2dee5 100644
--- a/chrome/browser/sync/protocol/typed_url_specifics.proto
+++ b/chrome/browser/sync/protocol/typed_url_specifics.proto
@@ -23,14 +23,23 @@ message TypedUrlSpecifics {
optional string url = 1;
// Title of the page corresponding to this URL.
optional string title = 2;
- // The number of times this URL was typed.
- optional int32 typed_count = 3;
+ // The number of times this URL was typed. Deprecated since we no longer sync
+ // this information (it's inferred by the history code from the transition
+ // type for each visit).
+ // optional int32 typed_count = 3; (deprecated)
// True if the URL should be used for auto-complete.
optional bool hidden = 4;
// The number of visits (includes page reloads).
- repeated int64 visit = 5;
- // The number of explicit navigations to this URL (excludes page reloads).
- optional int32 visited_count = 6;
+ // repeated int64 visit = 5; (deprecated)
+ // The number of explicit navigations to this URL (excludes page reloads) -
+ // deprecated as we no longer sync this (history code infers this from the
+ // |visits| array).
+ // optional int32 visited_count = 6; (deprecated)
+ // Timestamps for all visits to this URL.
+ repeated int64 visits = 7 [packed=true];
+ // The PageTransition::Type for each of the visits in the |visit| array. Both
+ // arrays must be the same length.
+ repeated int32 visit_transitions = 8 [packed=true];
}
extend EntitySpecifics {
« no previous file with comments | « chrome/browser/sync/protocol/proto_value_conversions.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698