Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1582)

Unified Diff: chrome/browser/history/history_backend_unittest.cc

Issue 7104088: Changed typed url sync to no longer modify typed/visit_count. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated per review comments. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_backend.cc ('k') | chrome/browser/history/history_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_backend_unittest.cc
diff --git a/chrome/browser/history/history_backend_unittest.cc b/chrome/browser/history/history_backend_unittest.cc
index effd02046c84fca4bd66e491b6a5f600e5773550..c6f10fcadf50c4f85f7f378480fa25f37f837d7c 100644
--- a/chrome/browser/history/history_backend_unittest.cc
+++ b/chrome/browser/history/history_backend_unittest.cc
@@ -696,15 +696,18 @@ TEST_F(HistoryBackendTest, AddVisitsSource) {
ASSERT_TRUE(backend_.get());
GURL url1("http://www.cnn.com");
- std::vector<base::Time> visits1;
- visits1.push_back(Time::Now() - base::TimeDelta::FromDays(5));
- visits1.push_back(Time::Now() - base::TimeDelta::FromDays(1));
- visits1.push_back(Time::Now());
+ std::vector<VisitInfo> visits1, visits2;
+ visits1.push_back(VisitInfo(
+ Time::Now() - base::TimeDelta::FromDays(5), PageTransition::LINK));
+ visits1.push_back(VisitInfo(
+ Time::Now() - base::TimeDelta::FromDays(1), PageTransition::LINK));
+ visits1.push_back(VisitInfo(
+ Time::Now(), PageTransition::LINK));
GURL url2("http://www.example.com");
- std::vector<base::Time> visits2;
- visits2.push_back(Time::Now() - base::TimeDelta::FromDays(10));
- visits2.push_back(Time::Now());
+ visits2.push_back(VisitInfo(
+ Time::Now() - base::TimeDelta::FromDays(10), PageTransition::LINK));
+ visits2.push_back(VisitInfo(Time::Now(), PageTransition::LINK));
// Clear all history.
backend_->DeleteAllHistory();
@@ -737,14 +740,15 @@ TEST_F(HistoryBackendTest, RemoveVisitsSource) {
ASSERT_TRUE(backend_.get());
GURL url1("http://www.cnn.com");
- std::vector<base::Time> visits1;
- visits1.push_back(Time::Now() - base::TimeDelta::FromDays(5));
- visits1.push_back(Time::Now());
+ std::vector<VisitInfo> visits1, visits2;
+ visits1.push_back(VisitInfo(
+ Time::Now() - base::TimeDelta::FromDays(5), PageTransition::LINK));
+ visits1.push_back(VisitInfo(Time::Now(), PageTransition::LINK));
GURL url2("http://www.example.com");
- std::vector<base::Time> visits2;
- visits2.push_back(Time::Now() - base::TimeDelta::FromDays(10));
- visits2.push_back(Time::Now());
+ visits2.push_back(VisitInfo(
+ Time::Now() - base::TimeDelta::FromDays(10), PageTransition::LINK));
+ visits2.push_back(VisitInfo(Time::Now(), PageTransition::LINK));
// Clear all history.
backend_->DeleteAllHistory();
« no previous file with comments | « chrome/browser/history/history_backend.cc ('k') | chrome/browser/history/history_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698