Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: chrome/browser/history/history_backend.h

Issue 7104088: Changed typed url sync to no longer modify typed/visit_count. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index cf4a099f5fc9a47ae1870d15d8007fbd8a14cf1a..0fd61579f421e4363463b34ca4631a482b0505c0 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -282,7 +282,8 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// While adding visits in batch, the source needs to be provided.
virtual bool AddVisits(const GURL& url,
- const std::vector<base::Time>& visits,
+ const std::vector<std::pair<
sky 2011/06/09 20:49:01 How about some typedefs for these in history_types
Andrew T Wilson (Slow) 2011/06/09 22:11:36 Added VisitInfo.
+ base::Time, PageTransition::Type> >& visits,
VisitSource visit_source);
virtual bool RemoveVisits(const VisitVector& visits);
@@ -315,7 +316,8 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
void SetOnBackendDestroyTask(MessageLoop* message_loop, Task* task);
// Adds the given rows to the database if it doesn't exist. A visit will be
- // added for each given URL at the last visit time in the URLRow.
+ // added for each given URL at the last visit time in the URLRow if the
+ // passed visit type != SOURCE_SYNCED (the sync code manages visits itself).
// Each visit will have the visit_source type set.
void AddPagesWithDetails(const std::vector<URLRow>& info,
VisitSource visit_source);

Powered by Google App Engine
This is Rietveld 408576698