Convert PageActionImageView context menu to MenuItemView.

Convert PageActionImageView context menu to MenuItemView.

BUG=chromium-os:13887
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88555

[sky, 2011-06-09 17:26:49]

LGTM

But I have another thought. Can we just make Menu2 do all this? That way you
shouldn't have to patch any call sites.

  -Scott

[rhashimoto, 2011-06-09 17:36:34]

On 2011/06/09 17:26:49, sky wrote:
> But I have another thought. Can we just make Menu2 do all this? That way you
> shouldn't have to patch any call sites.

You mean have Menu2 be a wrapper around MenuItemView?

I think I have all but one of the cases coded (except for RenderViewContextMenu
which takes some Chrome Frame work) ; I'm just trying to test them all and then
get them through review.

[sky, 2011-06-09 17:41:21]

On Thu, Jun 9, 2011 at 10:36 AM,  <rhashimoto@chromium.org> wrote:
> On 2011/06/09 17:26:49, sky wrote:
>>
>> But I have another thought. Can we just make Menu2 do all this? That way
>> you
>> shouldn't have to patch any call sites.
>
> You mean have Menu2 be a wrapper around MenuItemView?

Not a wrapper, but internally use MenuItemView.

> I think I have all but one of the cases coded (except for
> RenderViewContextMenu
> which takes some Chrome Frame work) ; I'm just trying to test them all and
> then
> get them through review.

Ok. I think ChromeFrame is going to be hard to change as it wants a
menu HWND, or something.

If you're almost done, keep down this path. Presumably when you're
done we can then nuke menu2 and related classes:)

  -Scott

[rhashimoto, 2011-06-09 17:53:27]

On 2011/06/09 17:41:21, sky wrote:
> Ok. I think ChromeFrame is going to be hard to change as it wants a
> menu HWND, or something.

Yes, that's correct.  Ben suggested an avenue of attack and I'm attempting to
figure that out now.  You're right, it looks like a challenge! :-)

> If you're almost done, keep down this path. Presumably when you're
> done we can then nuke menu2 and related classes:)

I have skipped a few not used in ChromeOS:

chrome/browser/ui/views/bookmarks/bookmark_editor_view.h
chrome/browser/ui/views/notifications/balloon_view.h
chrome/browser/ui/views/download/download_shelf_context_menu_view.h

But I can eventually convert these, too.

Thanks, Scott!

[commit-bot: I haz the power, 2011-06-09 18:29:20]

Change committed as 88555