Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 7104085: In chromedriver, add /log handler (Closed)

Created:
9 years, 6 months ago by kkania
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

In chromedriver, add /log url to get the contents of the chromedriver log remotely. Also add a 'chrome.verbose' boolean startup option. Remove usage of VLOG(1) in chromedriver. We do not need as complicated logging as in Chrome. BUG=85241 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88591

Patch Set 1 #

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3531 lines, -3473 lines) Patch
M chrome/chrome_tests.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/automation/automation_json_requests.h View 1 chunk +335 lines, -327 lines 0 comments Download
M chrome/test/automation/automation_json_requests.cc View 1 chunk +632 lines, -637 lines 0 comments Download
M chrome/test/webdriver/automation.cc View 1 chunk +665 lines, -665 lines 0 comments Download
M chrome/test/webdriver/chromedriver_tests.py View 1 chunk +626 lines, -601 lines 0 comments Download
M chrome/test/webdriver/commands/create_session.cc View 1 chunk +123 lines, -108 lines 0 comments Download
M chrome/test/webdriver/commands/webdriver_command.cc View 1 chunk +61 lines, -60 lines 0 comments Download
M chrome/test/webdriver/dispatch.h View 1 chunk +139 lines, -130 lines 0 comments Download
M chrome/test/webdriver/dispatch.cc View 1 chunk +340 lines, -299 lines 0 comments Download
M chrome/test/webdriver/keymap.cc View 1 chunk +177 lines, -177 lines 0 comments Download
M chrome/test/webdriver/server.cc View 1 chunk +246 lines, -265 lines 0 comments Download
M chrome/test/webdriver/session_manager.cc View 1 chunk +85 lines, -89 lines 0 comments Download
M chrome/test/webdriver/utility_functions.h View 1 chunk +17 lines, -32 lines 0 comments Download
M chrome/test/webdriver/utility_functions.cc View 1 chunk +20 lines, -83 lines 0 comments Download
A chrome/test/webdriver/webdriver_logging.h View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/test/webdriver/webdriver_logging.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kkania
Same as last CL; it got reverted because dispatch.cc:92 clang was upset about comparing an ...
9 years, 6 months ago (2011-06-09 14:38:59 UTC) #1
kkania
Well, not exactly the same; I changed the constant in dispatch.cc to be unsigned
9 years, 6 months ago (2011-06-09 14:39:41 UTC) #2
Huyen
Assuming everything else remained the same from last CL except for change in dispatch.cc, LGTM.
9 years, 6 months ago (2011-06-09 17:47:38 UTC) #3
commit-bot: I haz the power
9 years, 6 months ago (2011-06-09 21:20:21 UTC) #4
Change committed as 88591

Powered by Google App Engine
This is Rietveld 408576698