Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 7104078: Fix ExecuteScriptApiTest.NavigationRace flakiness. (Closed)

Created:
9 years, 6 months ago by Mihai Parparita -not on Chrome
Modified:
9 years, 6 months ago
Reviewers:
Ben Olmstead
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix ExecuteScriptApiTest.NavigationRace flakiness. The test only appeared to time out when running two tests per test case. It does not when splitting up the execute_script and javascript_url subtests into two test cases. No other tests run two extension tests per test case either. R=bolms@chromium.org BUG=78802 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/extensions/execute_script_apitest.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mihai Parparita -not on Chrome
9 years, 6 months ago (2011-06-09 01:10:57 UTC) #1
Ben Olmstead
9 years, 6 months ago (2011-06-09 01:22:56 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698